Merge pull request matplotlib#24262 from oscargus/tickspinefix

Fix issue with space allocated for single tick that should not be there

Author: ksunden

lib/matplotlib/spines.py

@@ -152,15 +152,16 @@ def get_window_extent(self, renderer=None):
         # make sure the location is updated so that transforms etc are correct:
         self._adjust_location()
         bb = super().get_window_extent(renderer=renderer)
-        if self.axis is None:
+        if self.axis is None or not self.axis.get_visible():
             return bb
         bboxes = [bb]
-        tickstocheck = [self.axis.majorTicks[0]]
-        if len(self.axis.minorTicks) > 1:
-            # only pad for minor ticks if there are more than one
-            # of them.  There is always one...
-            tickstocheck.append(self.axis.minorTicks[1])
-        for tick in tickstocheck:
+        drawn_ticks = self.axis._update_ticks()
+
+        major_tick = next(iter({*drawn_ticks} & {*self.axis.majorTicks}), None)
+        minor_tick = next(iter({*drawn_ticks} & {*self.axis.minorTicks}), None)
+        for tick in [major_tick, minor_tick]:
+            if tick is None:
+                continue
             bb0 = bb.frozen()
             tickl = tick._size
             tickdir = tick._tickdir

lib/matplotlib/tests/baseline_images/test_colorbar/colorbar_keeping_xlabel.png

@@ -134,3 +134,17 @@ def test_label_without_ticks():
         spine.get_path()).get_extents()
     assert ax.xaxis.label.get_position()[1] < spinebbox.ymin, \
         "X-Axis label not below the spine"
+
+
+@image_comparison(['black_axes'])
+def test_spines_black_axes():
+    # GitHub #18804
+    plt.rcParams["savefig.pad_inches"] = 0
+    plt.rcParams["savefig.bbox"] = 'tight'
+    fig = plt.figure(0, figsize=(4, 4))
+    ax = fig.add_axes((0, 0, 1, 1))
+    ax.set_xticklabels([])
+    ax.set_yticklabels([])
+    ax.set_xticks([])
+    ax.set_yticks([])
+    ax.set_facecolor((0, 0, 0))