Skip to content

Commit 20c1c7f

Browse files
AA-TurnerAA-Turner
committed
Use list literals
1 parent 546dd50 commit 20c1c7f

File tree

5 files changed

+27
-49
lines changed

5 files changed

+27
-49
lines changed

‎sphinx/builders/_epub_base.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -708,8 +708,7 @@ def build_navpoints(self, nodes: list[dict[str, Any]]) -> list[NavPoint]:
708708
Subelements of a node are nested inside the navpoint. For nested nodes
709709
the parent node is reinserted in the subnav.
710710
"""
711-
navstack: list[NavPoint] = []
712-
navstack.append(NavPoint('dummy', 0, '', '', []))
711+
navstack: list[NavPoint] = [NavPoint('dummy', 0, '', '', [])]
713712
level = 0
714713
lastnode = None
715714
for node in nodes:

‎sphinx/builders/epub3.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,7 @@ def build_navlist(self, navnodes: list[dict[str, Any]]) -> list[NavPoint]:
141141
The difference from build_navpoints method is templates which are used
142142
when generating navigation documents.
143143
"""
144-
navstack: list[NavPoint] = []
145-
navstack.append(NavPoint('', '', []))
144+
navstack: list[NavPoint] = [NavPoint('', '', [])]
146145
level = 0
147146
for node in navnodes:
148147
if not node['text']:

‎sphinx/domains/c/_ast.py‎

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -657,8 +657,7 @@ def __hash__(self) -> int:
657657
return hash((self.exprs, self.ops))
658658

659659
def _stringify(self, transform: StringifyTransform) -> str:
660-
res = []
661-
res.append(transform(self.exprs[0]))
660+
res = [transform(self.exprs[0])]
662661
for i in range(1, len(self.exprs)):
663662
res.extend((
664663
' ',
@@ -699,8 +698,7 @@ def __hash__(self) -> int:
699698
return hash((self.exprs, self.ops))
700699

701700
def _stringify(self, transform: StringifyTransform) -> str:
702-
res = []
703-
res.append(transform(self.exprs[0]))
701+
res = [transform(self.exprs[0])]
704702
for i in range(1, len(self.exprs)):
705703
res.extend((
706704
' ',
@@ -872,8 +870,7 @@ def function_params(self) -> list[ASTFunctionParameter]:
872870
return self.args
873871

874872
def _stringify(self, transform: StringifyTransform) -> str:
875-
res = []
876-
res.append('(')
873+
res = ['(']
877874
first = True
878875
for a in self.args:
879876
if not first:
@@ -1345,8 +1342,7 @@ def require_space_after_declSpecs(self) -> bool:
13451342
)
13461343

13471344
def _stringify(self, transform: StringifyTransform) -> str:
1348-
res = ['*']
1349-
res.append(transform(self.attrs))
1345+
res = ['*', transform(self.attrs)]
13501346
if len(self.attrs) != 0 and (self.restrict or self.volatile or self.const):
13511347
res.append(' ')
13521348
if self.restrict:
@@ -1620,8 +1616,7 @@ def get_id(self, version: int, objectType: str, symbol: Symbol) -> str:
16201616
return self.type.get_id(version, objectType, symbol)
16211617

16221618
def _stringify(self, transform: StringifyTransform) -> str:
1623-
res = []
1624-
res.append(transform(self.type))
1619+
res = [transform(self.type)]
16251620
if self.init:
16261621
res.append(transform(self.init))
16271622
return ''.join(res)
@@ -1699,8 +1694,7 @@ def get_id(self, version: int, objectType: str, symbol: Symbol) -> str:
16991694
return symbol.get_full_nested_name().get_id(version)
17001695

17011696
def _stringify(self, transform: StringifyTransform) -> str:
1702-
res = []
1703-
res.append(transform(self.ident))
1697+
res = [transform(self.ident)]
17041698
if self.args is not None:
17051699
res.append('(')
17061700
first = True
@@ -1826,8 +1820,7 @@ def get_id(self, version: int, objectType: str, symbol: Symbol) -> str:
18261820
return symbol.get_full_nested_name().get_id(version)
18271821

18281822
def _stringify(self, transform: StringifyTransform) -> str:
1829-
res = []
1830-
res.append(transform(self.name))
1823+
res = [transform(self.name)]
18311824
if len(self.attrs) != 0:
18321825
res.extend((' ', transform(self.attrs)))
18331826
if self.init:

‎sphinx/domains/cpp/_ast.py‎

Lines changed: 14 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1314,8 +1314,7 @@ def __hash__(self) -> int:
13141314
return hash((self.exprs, self.ops))
13151315

13161316
def _stringify(self, transform: StringifyTransform) -> str:
1317-
res = []
1318-
res.append(transform(self.exprs[0]))
1317+
res = [transform(self.exprs[0])]
13191318
for i in range(1, len(self.exprs)):
13201319
res.extend((
13211320
' ',
@@ -1804,8 +1803,7 @@ def get_id(self, version: int) -> str:
18041803
))
18051804
return ''.join(res)
18061805

1807-
res = []
1808-
res.append('I')
1806+
res = ['I']
18091807
if len(self.args) > 0:
18101808
for a in self.args[:-1]:
18111809
res.append(a.get_id(version))
@@ -2172,8 +2170,7 @@ def get_param_id(self, version: int) -> str:
21722170
return ''.join(a.get_id(version) for a in self.args)
21732171

21742172
def _stringify(self, transform: StringifyTransform) -> str:
2175-
res = []
2176-
res.append('(')
2173+
res = ['(']
21772174
first = True
21782175
for a in self.args:
21792176
if not first:
@@ -2485,8 +2482,7 @@ def __hash__(self) -> int:
24852482

24862483
def get_id(self, version: int) -> str:
24872484
if version == 1:
2488-
res = []
2489-
res.append(self.trailingTypeSpec.get_id(version))
2485+
res = [self.trailingTypeSpec.get_id(version)]
24902486
if self.allSpecs.volatile:
24912487
res.append('V')
24922488
if self.allSpecs.const:
@@ -2689,9 +2685,8 @@ def get_ptr_suffix_id(self, version: int) -> str: # only the array specifiers
26892685

26902686
def get_type_id(self, version: int, returnTypeId: str) -> str:
26912687
assert version >= 2
2692-
res = []
2688+
res = [self.get_ptr_suffix_id(version)]
26932689
# TODO: can we actually have both array ops and paramQual?
2694-
res.append(self.get_ptr_suffix_id(version))
26952690
if self.paramQual:
26962691
res.extend((
26972692
self.get_modifiers_id(version),
@@ -2834,8 +2829,7 @@ def require_space_after_declSpecs(self) -> bool:
28342829
return self.next.require_space_after_declSpecs()
28352830

28362831
def _stringify(self, transform: StringifyTransform) -> str:
2837-
res = ['*']
2838-
res.append(transform(self.attrs))
2832+
res = ['*', transform(self.attrs)]
28392833
if len(self.attrs) != 0 and (self.volatile or self.const):
28402834
res.append(' ')
28412835
if self.volatile:
@@ -2866,8 +2860,7 @@ def get_ptr_suffix_id(self, version: int) -> str:
28662860
res.append(self.next.get_ptr_suffix_id(version))
28672861
return ''.join(res)
28682862

2869-
res = [self.next.get_ptr_suffix_id(version)]
2870-
res.append('P')
2863+
res = [self.next.get_ptr_suffix_id(version), 'P']
28712864
if self.volatile:
28722865
res.append('V')
28732866
if self.const:
@@ -2949,8 +2942,7 @@ def require_space_after_declSpecs(self) -> bool:
29492942
return self.next.require_space_after_declSpecs()
29502943

29512944
def _stringify(self, transform: StringifyTransform) -> str:
2952-
res = ['&']
2953-
res.append(transform(self.attrs))
2945+
res = ['&', transform(self.attrs)]
29542946
if len(self.attrs) != 0 and self.next.require_space_after_declSpecs():
29552947
res.append(' ')
29562948
res.append(transform(self.next))
@@ -3565,8 +3557,7 @@ def get_id(
35653557
return symbol.get_full_nested_name().get_id(version)
35663558

35673559
def _stringify(self, transform: StringifyTransform) -> str:
3568-
res = []
3569-
res.append(transform(self.type))
3560+
res = [transform(self.type)]
35703561
if self.init:
35713562
res.append(transform(self.init))
35723563
return ''.join(res)
@@ -3601,8 +3592,7 @@ def get_id(
36013592
return symbol.get_full_nested_name().get_id(version)
36023593

36033594
def _stringify(self, transform: StringifyTransform) -> str:
3604-
res = []
3605-
res.append(transform(self.name))
3595+
res = [transform(self.name)]
36063596
if self.type:
36073597
res.extend((' = ', transform(self.type)))
36083598
return ''.join(res)
@@ -3745,8 +3735,7 @@ def get_id(self, version: int, objectType: str, symbol: Symbol) -> str:
37453735
return symbol.get_full_nested_name().get_id(version)
37463736

37473737
def _stringify(self, transform: StringifyTransform) -> str:
3748-
res = []
3749-
res.append(transform(self.attrs))
3738+
res = [transform(self.attrs)]
37503739
if len(self.attrs) != 0:
37513740
res.append(' ')
37523741
res.append(transform(self.name))
@@ -3804,8 +3793,7 @@ def get_id(self, version: int, objectType: str, symbol: Symbol) -> str:
38043793
return symbol.get_full_nested_name().get_id(version)
38053794

38063795
def _stringify(self, transform: StringifyTransform) -> str:
3807-
res = []
3808-
res.append(transform(self.attrs))
3796+
res = [transform(self.attrs)]
38093797
if len(self.attrs) != 0:
38103798
res.append(' ')
38113799
res.append(transform(self.name))
@@ -3908,8 +3896,7 @@ def get_id(self, version: int, objectType: str, symbol: Symbol) -> str:
39083896
return symbol.get_full_nested_name().get_id(version)
39093897

39103898
def _stringify(self, transform: StringifyTransform) -> str:
3911-
res = []
3912-
res.append(transform(self.name))
3899+
res = [transform(self.name)]
39133900
if len(self.attrs) != 0:
39143901
res.extend((' ', transform(self.attrs)))
39153902
if self.init:
@@ -4211,8 +4198,7 @@ def __hash__(self) -> int:
42114198

42124199
def get_id(self, version: int, excludeRequires: bool = False) -> str:
42134200
assert version >= 2
4214-
res = []
4215-
res.append('I')
4201+
res = ['I']
42164202
res.extend(param.get_id(version) for param in self.params)
42174203
res.append('E')
42184204
if not excludeRequires and self.requiresClause:

‎sphinx/domains/cpp/_parser.py‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -495,9 +495,10 @@ def parser() -> ASTExpression:
495495
self.pos = pos
496496
header = 'Error in postfix expression,'
497497
header += ' expected primary expression or type.'
498-
errors = []
499-
errors.append((e_outer, 'If primary expression'))
500-
errors.append((e_inner, 'If type'))
498+
errors = [
499+
(e_outer, 'If primary expression'),
500+
(e_inner, 'If type'),
501+
]
501502
raise self._make_multi_error(errors, header) from e_inner
502503

503504
# and now parse postfixes

0 commit comments

Comments
 (0)