improve typing of certain functions

Author: aviatesk

src/callbacks.jl

@@ -30,8 +30,6 @@ Global variable, maps callback keys to user hooks.
 """
 const user_callbacks_by_key = Dict{Any, Any}()
 
-
-
 """
     key = Revise.add_callback(f, files, modules=nothing; key=gensym())
 

src/packagedef.jl

@@ -537,13 +537,13 @@ end
 init_watching(files) = init_watching(pkgdatas[NOPACKAGE], files)
 
 """
-    revise_dir_queued(dirname)
+    revise_dir_queued(dirname::AbstractString)
 
 Wait for one or more of the files registered in `Revise.watched_files[dirname]` to be
 modified, and then queue the corresponding files on [`Revise.revision_queue`](@ref).
 This is generally called via a [`Revise.TaskThunk`](@ref).
 """
-@noinline function revise_dir_queued(dirname)
+@noinline function revise_dir_queued(dirname::AbstractString)
     @assert isabspath(dirname)
     if !isdir(dirname)
         sleep(0.1)   # in case git has done a delete/replace cycle

src/pkgs.jl

@@ -390,7 +390,7 @@ end
 
 # Much of this is adapted from base/loading.jl
 
-function manifest_file(project_file)
+function manifest_file(project_file = Base.active_project())
     if project_file isa String && isfile(project_file)
         mfile = Base.project_file_manifest_path(project_file)
         if mfile isa String
@@ -399,7 +399,6 @@ function manifest_file(project_file)
     end
     return nothing
 end
-manifest_file() = manifest_file(Base.active_project())
 
 function manifest_paths!(pkgpaths::Dict, manifest_file::String)
     d = if isdefined(Base, :get_deps) # `get_deps` is present in versions that support new manifest formats
@@ -427,7 +426,7 @@ end
 manifest_paths(manifest_file::String) =
     manifest_paths!(Dict{PkgId,String}(), manifest_file)
 
-function watch_manifest(mfile)
+function watch_manifest(mfile::String)
     while true
         try
             wait_changed(mfile)

src/recipes.jl

@@ -14,7 +14,7 @@ end
 
 const vstring = "v$(VERSION.major).$(VERSION.minor)"
 
-function inpath(path, dirs)
+function inpath(path::AbstractString, dirs::Vector{String})
     spath = splitpath(path)
     idx = findfirst(isequal(first(dirs)), spath)
     idx === nothing && return false
@@ -29,15 +29,15 @@ function inpath(path, dirs)
     return true
 end
 
-function _track(id, modname; modified_files=revision_queue)
+function _track(id::PkgId, modname::Symbol; modified_files=revision_queue)
     haskey(pkgdatas, id) && return nothing  # already tracked
     isbase = modname === :Base
     isstdlib = !isbase && modname ∈ stdlib_names
     if isbase || isstdlib
         # Test whether we know where to find the files
         if isbase
             srcdir = fixpath(joinpath(juliadir, "base"))
-            dirs = ["base"]
+            dirs = String["base"]
         else
             stdlibv = joinpath("stdlib", vstring, String(modname))
             srcdir = fixpath(joinpath(juliadir, stdlibv))
@@ -48,7 +48,7 @@ function _track(id, modname; modified_files=revision_queue)
                 # This can happen for Pkg, since it's developed out-of-tree
                 srcdir = joinpath(juliadir, "usr", "share", "julia", stdlibv)  # omit fixpath deliberately
             end
-            dirs = ["stdlib", String(modname)]
+            dirs = String["stdlib", String(modname)]
         end
         if !isdir(srcdir)
             @error "unable to find path containing source for $modname, tracking is not possible"

src/relocatable_exprs.jl

@@ -73,7 +73,7 @@ function Base.iterate(iter::LineSkippingIterator, i=0)
     return (iter.args[i], i)
 end
 
-function skip_to_nonline(args, i)
+function skip_to_nonline(args::Vector{Any}, i::Int)
     while true
         i > length(args) && return i
         ex = args[i]

src/utils.jl

@@ -87,7 +87,7 @@ function unwrap(ex::Expr)
 end
 unwrap(rex::RelocatableExpr) = RelocatableExpr(unwrap(rex.ex))
 
-istrivial(a) = a === nothing || isa(a, LineNumberNode)
+istrivial(@nospecialize a) = a === nothing || isa(a, LineNumberNode)
 
 function unwrap_where(ex::Expr)
     while isexpr(ex, :where)