Skip to content

Commit 58cd2cb

Browse files
authored
Circumvent CI hang on 1.8 (#722)
#710 attempted to debug a Requires-based hang that seems to only occur on CI with Julia 1.8. It may be due to lock contention, but the precise case was not obvious. This just disables the problematic test. Since it doesn't happen on nightly, and since Requires will be supplanted by the new weakdeps mechanism, we can direct any users who encounter this bug to the alternatives.
1 parent 57940f7 commit 58cd2cb

File tree

1 file changed

+17
-15
lines changed

1 file changed

+17
-15
lines changed

test/runtests.jl

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3144,18 +3144,20 @@ do_test("New files & Requires.jl") && @testset "New files & Requires.jl" begin
31443144
@test isempty(read(warnfile, String))
31453145
# Issue #431
31463146
@test_throws UndefVarError TrackRequires.ftrack()
3147-
@eval using RoundingIntegers
3148-
sleep(2) # allow time for the @async in all @require blocks to finish
3149-
if notified
3150-
@test TrackRequires.ftrack() == 1
3151-
id = Base.PkgId(TrackRequires)
3152-
pkgdata = Revise.pkgdatas[id]
3153-
sf = Revise.srcfiles(pkgdata)
3154-
@test count(name->occursin("@require", name), sf) == 1
3155-
@test count(name->occursin("anotherfile", name), sf) == 1
3156-
@test !any(isequal("."), sf)
3157-
idx = findfirst(name->occursin("anotherfile", name), sf)
3158-
@test !isabspath(sf[idx])
3147+
if !(get(ENV, "CI", nothing) == "true" && Base.VERSION.major == 1 && Base.VERSION.minor == 8) # circumvent CI hang
3148+
@eval using RoundingIntegers
3149+
sleep(2) # allow time for the @async in all @require blocks to finish
3150+
if notified
3151+
@test TrackRequires.ftrack() == 1
3152+
id = Base.PkgId(TrackRequires)
3153+
pkgdata = Revise.pkgdatas[id]
3154+
sf = Revise.srcfiles(pkgdata)
3155+
@test count(name->occursin("@require", name), sf) == 1
3156+
@test count(name->occursin("anotherfile", name), sf) == 1
3157+
@test !any(isequal("."), sf)
3158+
idx = findfirst(name->occursin("anotherfile", name), sf)
3159+
@test !isabspath(sf[idx])
3160+
end
31593161
end
31603162
@test_throws UndefVarError TrackRequires.fauto()
31613163
@eval using UnsafeArrays
@@ -3535,14 +3537,14 @@ end
35353537

35363538
do_test("includet with mod arg (issue #689)") && @testset "includet with mod arg (issue #689)" begin
35373539
testdir = newtestdir()
3538-
3540+
35393541
common = joinpath(testdir, "common.jl")
35403542
write(common, """
35413543
module Common
35423544
const foo = 2
35433545
end
35443546
""")
3545-
3547+
35463548
routines = joinpath(testdir, "routines.jl")
35473549
write(routines, """
35483550
module Routines
@@ -3551,7 +3553,7 @@ do_test("includet with mod arg (issue #689)") && @testset "includet with mod arg
35513553
using .Common
35523554
end
35533555
""")
3554-
3556+
35553557
codes = joinpath(testdir, "codes.jl")
35563558
write(codes, """
35573559
module Codes

0 commit comments

Comments
 (0)