Skip to content

Commit a2c3f14

Browse files
committed
Fix miscellaneous test errors
- arg and type changes for different Julia versions - macOS error on fake_lang test - skip test-for-warning on macOS
1 parent 2512e85 commit a2c3f14

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,11 @@ jobs:
5757
while !isdefined(Base, :active_repl_backend) sleep(0.1) end
5858
pushfirst!(Base.active_repl_backend.ast_transforms, Revise.revise_first)
5959
include(joinpath("test", "runtests.jl"))
60-
REPL.eval_user_input(:(exit()), Base.active_repl_backend)
61-
' "Methods at REPL"
60+
if Base.VERSION.major == 1 && Base.VERSION.minor >= 9
61+
REPL.eval_user_input(:(exit()), Base.active_repl_backend, Main)
62+
else
63+
REPL.eval_user_input(:(exit()), Base.active_repl_backend)
64+
end' "Methods at REPL"
6265
# Tests for out-of-process updates to manifest
6366
bash test/envs/use_exputils/setup.sh
6467
julia --project --code-coverage=user test/envs/use_exputils/switch_version.jl

test/non_jl_test.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ try
3636
cp(joinpath(@__DIR__, "fake_lang", "test.program"), path, force=true)
3737
m=MyFile(path)
3838
includet(m)
39-
Revise.revise()
39+
yry() # comes from test/common.jl
4040
@test fake_lang.y() == "2"
4141
@test fake_lang.x() == "1"
4242
cp(joinpath(@__DIR__, "fake_lang", "new_test.program"), path, force=true)

test/runtests.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3621,7 +3621,7 @@ GC.gc(); GC.gc()
36213621
end
36223622
end
36233623
msg = Revise.watching_files[] ? "is not an existing file" : "is not an existing directory"
3624-
isempty(ARGS) && @test occursin(msg, read(warnfile, String))
3624+
isempty(ARGS) && !Sys.isapple() && @test occursin(msg, read(warnfile, String))
36253625
rm(warnfile)
36263626
end
36273627
end

test/sigtest.jl

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,11 @@ function extracttype(T)
5656
isa(p1, TypeVar) && return p1.ub
5757
error("unrecognized type ", T)
5858
end
59+
if isdefined(Core, :TypeofVararg)
60+
istva(T) = isa(T, Core.TypeofVararg)
61+
else
62+
istva(T) = false
63+
end
5964
function in_module_or_core(T, mod::Module)
6065
if isa(T, TypeVar)
6166
return in_module_or_core(T.ub, mod)
@@ -68,7 +73,7 @@ function in_module_or_core(T, mod::Module)
6873
in_module_or_core(T.a, mod) || return false
6974
return in_module_or_core(T.b, mod)
7075
end
71-
if isa(T, Core.TypeofVararg)
76+
if istva(T)
7277
isdefined(T, :T) || return true
7378
return in_module_or_core(T.T, mod)
7479
end

0 commit comments

Comments
 (0)