Merged
Conversation
added 2 commits
November 11, 2025 17:43
KristofferC
reviewed
Nov 19, 2025
| global juliadir = find_juliadir() | ||
| global basesrccache = normpath(joinpath(expected_juliadir(), "base.cache")) | ||
| global depsdir = joinpath(isnothing(pkgdir(@__MODULE__)) ? dirname(@__DIR__) : pkgdir(@__MODULE__), "deps") | ||
| silencefile[] = joinpath(depsdir, "silence.txt") |
Collaborator
There was a problem hiding this comment.
Tangentially, the whole silence functionality should be rewritten using Preferences.jl instead of mutating the package folder.
Contributor
Author
There was a problem hiding this comment.
I am currently overwhelmed and refactoring to use Preferences.jl is not on my plate, but I support the change.
Owner
|
Thanks! |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Revise hardcodes paths at compilation time, which prevents its pkgimage cache from being relocatable. This creates issues when forming Julia distributions like Jumbo that need relocatable package caches.
This PR addresses the issue by converting the hardcoded path constants to uninitialized globals that are assigned in the
__init__function instead. Limited testing shows that the relocated Revise works fine with this approach.