Adjust for base paths possibly being non-normalized#974
Merged
Conversation
Keno
force-pushed
the
kf/nonormbasepaths
branch
from
4556a14 to
52ccbf9
Compare
Fixes test failures with JuliaLang/julia#60251. Also fixes an unrelated test where Revise was using the wrong PkgId for Core.Compiler (failure not seen on CI, because it's explicitly disabled there).
Keno
force-pushed
the
kf/nonormbasepaths
branch
from
52ccbf9 to
fce4964
Compare
Keno
added a commit
to JuliaDebug/CodeTracking.jl
that referenced
this pull request
Nov 27, 2025
Collaborator
Author
|
I'm not entirely happy with this in the sense that I don't think we have a principle'd answer as to how we're treating paths, but it's passing tests on both the old and the new version, which I think is good enough for now. This is one of those topics that I want to revisit after JuliaLowering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes test failures with JuliaLang/julia#60251. Also fixes an unrelated test where Revise was using the wrong PkgId for Core.Compiler (failure not seen on CI, because it's explicitly disabled there).