fix: Allow users to lower their level

Author: timniederhausen

src/bw_save_game/ui/__init__.py

@@ -812,7 +812,9 @@ def show_editor_main(state: State):
                 CLASS_KEYBINDING_LABELS,
             )
             if show_persisted_value_editor(state, "Level:", PROGRESSION_CurrentLevel):
-                state.save_game.change_level(state.save_game.get_persistence_property(PROGRESSION_CurrentLevel))
+                new_level = state.save_game.get_persistence_property(PROGRESSION_CurrentLevel)
+                if state.save_game.meta["projdata"]["level"] != new_level:
+                    state.save_game.change_level(new_level)
             if show_persisted_value_options_editor(
                 state,
                 "Voice",

src/bw_save_game/veilguard/highlevel.py

@@ -215,13 +215,8 @@ def change_level(self, new_level: int):
             if bucket["level"] == new_level:
                 min_xp_for_level = bucket["value"]
 
-        cur_xp = self.get_persistence_property(PROGRESSION_XP_XP)
-        if cur_xp < min_xp_for_level:
-            self.set_persistence_property(PROGRESSION_XP_XP, min_xp_for_level)
-
-        cur_xp = self.get_persistence_property(DEFAULTXPBUCKET_XP)
-        if cur_xp < min_xp_for_level:
-            self.set_persistence_property(DEFAULTXPBUCKET_XP, min_xp_for_level)
+        self.set_persistence_property(PROGRESSION_XP_XP, min_xp_for_level)
+        self.set_persistence_property(DEFAULTXPBUCKET_XP, min_xp_for_level)
 
 
 def deconstruct_item_attachment(item: dict) -> tuple[ItemAttachmentType, None | int | UUID, None | str]: