Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that dependencies
acornandacorn-jsxdeclared in thepackage.jsonfile are unused in the source files of the project. Removing these unused dependencies has an impact on the number of CI build minutes that are consumed during CI due to bumpings of unused dependencies by bots. In fact, I found 11 commits, bumping versions of these unused dependencies, recently made by the renovate bot, and those commits consume over 88 minutes of build time. Thus, removing the unused dependencies (including the ones I suggested) would save a substantial amount of CI build time.On the other hand, removing unused dependencies may reduce the number of pull requests needed to be reviewed by developers for such cases.