Fix MyPy Type Issues - Complex Type Annotation Work

[timothyfroehlich]

Overview

Address complex MyPy type checking issues that require systematic type annotation work.

Issues to Address

1. Discord.py Cog Class Issues

• Files: src/cogs/*.py
• Issue: Unexpected keyword argument "name" for "__init_subclass__" of "object"
• Complexity: Requires understanding Discord.py cog system and proper inheritance

2. Optional Type Annotations

• Files: src/database.py, src/notifier.py, src/api.py
• Issue: Incompatible default for argument with None defaults
• Complexity: Requires systematic addition of Optional[] type hints

3. Base Class Type Issues

• File: src/models.py
• Issue: Variable "src.models.Base" is not valid as a type
• Complexity: SQLAlchemy typing complexity

4. Import Redefinition Issues

• Files: src/database.py, src/main.py
• Issue: Name "Database" already defined (possibly by an import)
• Complexity: Module structure refactoring needed

Acceptance Criteria

• All MyPy errors resolved
• Proper type hints added throughout codebase
• Discord.py cog inheritance fixed
• SQLAlchemy models properly typed
• Import structure cleaned up

Created from linting infrastructure work.

[timothyfroehlich]

🎯 Major Progress Update - 3 out of 4 sub-issues resolved!

Significant MyPy type annotation improvements have been completed:

✅ RESOLVED Issues:

• Issue Fix Discord.py Cog Class Type Issues #9 - Discord.py Cog Class Type Issues (resolved by recent PRs)
• Issue Add Optional Type Annotations #10 - Optional Type Annotations (just completed)
• Issue Fix SQLAlchemy Base Class Type Issues #11 - SQLAlchemy Base Class Type Issues (just completed)
• Issue Fix Import Structure and Redefinition Issues #14 - Import Structure and Redefinition Issues (resolved by PR Phase 2: Linting fixes and GCP cost optimization with PostgreSQL preservation #21)

📊 Current MyPy Status:

• Before: 25+ complex type annotation errors
• After: Reduced to ~10 remaining errors (mostly SQLAlchemy Column assignment patterns)

🔧 Completed Work:

1. Optional Type Annotations: Fixed all "Incompatible default for argument" errors
2. SQLAlchemy Modernization: Migrated to SQLAlchemy 2.0+ DeclarativeBase pattern
3. Import Structure: Cleaned up redefinition issues via PR Phase 2: Linting fixes and GCP cost optimization with PostgreSQL preservation #21
4. Discord.py Compatibility: Cog inheritance now works with MyPy

📋 Remaining Work:

The last ~10 MyPy errors are primarily SQLAlchemy Column assignment patterns in database.py. These are more complex as they involve SQLAlchemy ORM internal typing patterns.

Status: This issue can be considered largely resolved with remaining errors being lower priority SQLAlchemy internals.