feat(notifications): notify users of their own actions by default

Users requested notifications for their own actions as a personal
record/reminder in their inbox. This changes the default behavior
of createNotification to include the actor in the recipient list.

Changes:
- notifications.ts: Set includeActor default to true
- issues.ts: Remove redundant includeActor: true flags (now default)
- issues.test.ts: Remove includeActor from test expectations
- Integration tests: Add explicit includeActor: false to tests that
  specifically test actor exclusion or recipient preference behavior
- database-queries.test.ts: Fix invalid UUID that was using
  "some-other-user-id" instead of a valid UUID format

Fixes #849

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: timothyfroehlich

src/lib/notifications.ts

@@ -44,7 +44,7 @@ export async function createNotification(
     resourceId,
     resourceType,
     actorId,
-    includeActor,
+    includeActor = true,
     issueTitle,
     machineName,
     formattedIssueId,

src/services/issues.test.ts

@@ -104,7 +104,6 @@ describe("Issue Service", () => {
           resourceId: issueId,
           resourceType: "issue",
           actorId,
-          includeActor: true,
           issueTitle: "Test Issue",
           machineName: "Test Machine",
           formattedIssueId: "MM-01",
@@ -144,7 +143,6 @@ describe("Issue Service", () => {
           resourceId: "issue-new",
           resourceType: "issue",
           actorId: "user-1",
-          includeActor: true,
           issueTitle: "New Issue",
           machineName: "Test Machine",
           formattedIssueId: "MM-01",

src/services/issues.ts

@@ -196,7 +196,6 @@ export async function createIssue({
           resourceId: issue.id,
           resourceType: "issue",
           ...(reportedBy ? { actorId: reportedBy } : {}),
-          includeActor: true,
           issueTitle: title,
           machineName: updatedMachine.name,
           formattedIssueId: formatIssueId(machineInitials, issueNumber),
@@ -282,7 +281,6 @@ export async function updateIssueStatus({
           resourceId: issueId,
           resourceType: "issue",
           actorId: userId,
-          includeActor: true,
           issueTitle: currentIssue.title,
           machineName: currentIssue.machine.name,
           formattedIssueId: formatIssueId(
@@ -506,7 +504,6 @@ export async function assignIssue({
             resourceId: issueId,
             resourceType: "issue",
             actorId,
-            includeActor: true,
             issueTitle: currentIssue.title,
             machineName: currentIssue.machine.name,
             formattedIssueId: formatIssueId(

src/test/integration/database-queries.test.ts

@@ -277,7 +277,8 @@ describe("Database Queries (PGlite)", () => {
           type: "new_issue",
           resourceId: issue.id,
           resourceType: "issue",
-          actorId: "some-other-user-id", // Actor is someone else
+          actorId: "00000000-0000-0000-0000-000000000002", // Actor is someone else
+          includeActor: false, // Exclude actor to test global watch behavior
           issueTitle: "Test Issue",
           machineName: "Test Machine",
           issueContext: {

src/test/integration/notifications.test.ts

@@ -66,6 +66,7 @@ describe("createNotification (Integration)", () => {
         resourceId: issue.id,
         resourceType: "issue",
         actorId: actor.id,
+        includeActor: false, // Explicitly test actor exclusion
         commentContent: "Test comment",
       },
       db
@@ -127,6 +128,7 @@ describe("createNotification (Integration)", () => {
         resourceId: issue.id,
         resourceType: "issue",
         actorId: actor.id,
+        includeActor: false, // Exclude actor to test recipient preferences
         commentContent: "Test comment",
       },
       db
@@ -186,6 +188,7 @@ describe("createNotification (Integration)", () => {
         resourceId: issue.id,
         resourceType: "issue",
         actorId: actor.id,
+        includeActor: false, // Exclude actor to test recipient granular toggles
         commentContent: "Test comment",
       },
       db