Applying ruff suggestions

Author: timsaucer

dev/release/generate-changelog.py

@@ -30,9 +30,7 @@ def print_pulls(repo_name, title, pulls):
         print()
         for pull, commit in pulls:
             url = f"https://github.com/{repo_name}/pull/{pull.number}"
-            print(
-                f"- {pull.title} [#{pull.number}]({url}) ({commit.author.login})"
-            )
+            print(f"- {pull.title} [#{pull.number}]({url}) ({commit.author.login})")
         print()
 
 

pyproject.toml

@@ -77,7 +77,7 @@ max-doc-length = 88
 
 # Disable docstring checking for these directories
 [tool.ruff.lint.per-file-ignores]
-"python/tests/*" = ["D"]
+"python/tests/*" = ["ANN", "ARG", "D", "S101", "SLF", "PD"]
 "examples/*" = ["D", "W505"]
 "dev/*" = ["D"]
 "benchmarks/*" = ["D", "F"]

python/datafusion/context.py

@@ -394,7 +394,6 @@ class RuntimeConfig(RuntimeEnvBuilder):
     """See `RuntimeEnvBuilder`."""
 
 
-
 class SQLOptions:
     """Options to be used when performing SQL queries."""
 

python/datafusion/substrait.py

@@ -72,7 +72,6 @@ class plan(Plan):
     """See `Plan`."""
 
 
-
 class Serde:
     """Provides the ``Substrait`` serialization and deserialization."""
 
@@ -143,7 +142,6 @@ class serde(Serde):
     """See `Serde` instead."""
 
 
-
 class Producer:
     """Generates substrait plans from a logical plan."""
 
@@ -170,7 +168,6 @@ class producer(Producer):
     """Use `Producer` instead."""
 
 
-
 class Consumer:
     """Generates a logical plan from a substrait plan."""
 
@@ -193,4 +190,3 @@ def from_substrait_plan(ctx: SessionContext, plan: Plan) -> LogicalPlan:
 @deprecated("Use `Consumer` instead.")
 class consumer(Consumer):
     """Use `Consumer` instead."""
-

python/tests/test_wrapper_coverage.py

@@ -19,6 +19,7 @@
 import datafusion.functions
 import datafusion.object_store
 import datafusion.substrait
+import pytest
 
 # EnumType introduced in 3.11. 3.10 and prior it was called EnumMeta.
 try:
@@ -41,10 +42,8 @@ def missing_exports(internal_obj, wrapped_obj) -> None:
         internal_attr = getattr(internal_obj, attr)
         wrapped_attr = getattr(wrapped_obj, attr)
 
-        if internal_attr is not None:
-            if wrapped_attr is None:
-                print("Missing attribute: ", attr)
-                assert False
+        if internal_attr is not None and wrapped_attr is None:
+                pytest.fail(f"Missing attribute: {attr}")
 
         if attr in ["__self__", "__class__"]:
             continue