Better implementation of copy_to_tmp

Morwenn · Morwenn · commit 5c46b9e0d6cf · 2019-10-12T20:39:21.000+02:00
diff --git a/include/gfx/timsort.hpp b/include/gfx/timsort.hpp
@@ -621,10 +621,13 @@ template <typename RandomAccessIterator, typename Compare> class TimSort {
         }
     }
 
-    void copy_to_tmp(iter_t const begin, diff_t const len) {
-        tmp_.clear();
-        tmp_.reserve(len);
-        GFX_TIMSORT_MOVE_RANGE(begin, begin + len, std::back_inserter(tmp_));
+    void copy_to_tmp(iter_t const begin, diff_t len) {
+#if GFX_TIMSORT_USE_STD_MOVE
+        tmp_.assign(std::make_move_iterator(begin),
+                    std::make_move_iterator(begin + len));
+#else
+        tmp_.assign(begin, begin + len);
+#endif
     }
 
     template <typename IterT, typename LessT>

Original file line number	Diff line number	Diff line change
`@@ -621,10 +621,13 @@ template <typename RandomAccessIterator, typename Compare> class TimSort {`
`621`	`621`	`}`
`622`	`622`	`}`
`623`	`623`
`624`		`- void copy_to_tmp(iter_t const begin, diff_t const len) {`
`625`		`- tmp_.clear();`
`626`		`- tmp_.reserve(len);`
`627`		`- GFX_TIMSORT_MOVE_RANGE(begin, begin + len, std::back_inserter(tmp_));`
	`624`	`+ void copy_to_tmp(iter_t const begin, diff_t len) {`
	`625`	`+#if GFX_TIMSORT_USE_STD_MOVE`
	`626`	`+ tmp_.assign(std::make_move_iterator(begin),`
	`627`	`+ std::make_move_iterator(begin + len));`
	`628`	`+#else`
	`629`	`+ tmp_.assign(begin, begin + len);`
	`630`	`+#endif`
`628`	`631`	`}`
`629`	`632`
`630`	`633`	`template <typename IterT, typename LessT>`