early returning in util.py

Author: timvink

mkdocs_git_authors_plugin/util.py

@@ -25,46 +25,48 @@ def get_authors(self, path):
         if authors == False:
             return []
 
-        if not authors:
-            try:
-                blame = self.repo.blame('HEAD',path)
-            except:
-                logging.warning("%s has no commits" % path)
-                self._authors[path] = False
-                return []
-
-            if len(Path(path).read_text()) == 0:
-                logging.warning("%s has no lines" % path)
-                self._authors[path] = False
-                return []
-
-            authors = {}
-            for commit, lines in blame:
-                key = commit.author.email
-
-                # Update existing author
-                if authors.get(key):
-                    authors[key]['lines'] = authors[key]['lines'] + len(lines)
-                    current_dt = authors.get(key,{}).get('last_datetime')
-                    if commit.committed_datetime > current_dt:
-                        authors[key]['last_datetime'] = commit.committed_datetime
-                # Add new author
-                else:
-                    authors[key] = {
-                        'name' : commit.author.name,
-                        'email' : key,
-                        'last_datetime' : commit.committed_datetime,
-                        'lines' : len(lines)
-                    }
-
-            authors = [authors[key] for key in authors]
-            authors = sorted(authors, key = lambda i: i['name'])
-
-            total_lines = sum([x.get('lines') for x in authors])
-            for author in authors:
-                author['contribution'] = self._format_perc(author['lines'] / total_lines)
-
-            self._authors[path] = authors
+        if authors:
+            return authors
+        
+        try:
+            blame = self.repo.blame('HEAD',path)
+        except:
+            logging.warning("%s has no commits" % path)
+            self._authors[path] = False
+            return []
+
+        if len(Path(path).read_text()) == 0:
+            logging.warning("%s has no lines" % path)
+            self._authors[path] = False
+            return []
+
+        authors = {}
+        for commit, lines in blame:
+            key = commit.author.email
+
+            # Update existing author
+            if authors.get(key):
+                authors[key]['lines'] = authors[key]['lines'] + len(lines)
+                current_dt = authors.get(key,{}).get('last_datetime')
+                if commit.committed_datetime > current_dt:
+                    authors[key]['last_datetime'] = commit.committed_datetime
+            # Add new author
+            else:
+                authors[key] = {
+                    'name' : commit.author.name,
+                    'email' : key,
+                    'last_datetime' : commit.committed_datetime,
+                    'lines' : len(lines)
+                }
+
+        authors = [authors[key] for key in authors]
+        authors = sorted(authors, key = lambda i: i['name'])
+
+        total_lines = sum([x.get('lines') for x in authors])
+        for author in authors:
+            author['contribution'] = self._format_perc(author['lines'] / total_lines)
+
+        self._authors[path] = authors
 
         return authors