major oauth character encoding fix

Author: Tim Whitlock

lib/twitter.js

@@ -7,7 +7,7 @@
 // pseudo constants
 //
 var TWITTER_API_TIMEOUT             = 10000,
-    TWITTER_API_USERAGENT           = 'Node/'+process.version.substr(1),
+    TWITTER_API_USERAGENT           = 'Node/'+process.version.substr(1)+'; https://github.com/timwhitlock/node-twitter-api',
     TWITTER_API_BASE                = 'https://api.twitter.com/1.1',
     TWITTER_STREAM_BASE             = 'https://stream.twitter.com/1.1',
     TWITTER_OAUTH_REQUEST_TOKEN_URL = 'https://twitter.com/oauth/request_token',
@@ -18,7 +18,31 @@ var TWITTER_API_TIMEOUT             = 10000,
     TWITTER_OAUTH2_INVALIDATE_URL   = 'https://api.twitter.com/oauth2/invalidate_token';
 
 
+/**
+ * OAuth safe encodeURIComponent of string
+ * handles ignored characters that OAuth expects encoded "! * ' ( )"
+ */
+function uriEncodeString( text ){
+    return encodeURIComponent(text).replace( /[\!\*\'\(\)]/g, function( chr ){
+        chr = chr.charCodeAt(0).toString(16);
+        while( chr.length < 2 ){
+            chr = '0'+hex;
+        }
+        return '%'+chr;
+    } )
+}
+
 
+/**
+ * OAuth safe encodeURIComponent of params object
+ */
+function uriEncodeParams( obj ){
+    var pairs = [], key;
+    for( key in obj ){
+        pairs.push( uriEncodeString(key) +'='+ uriEncodeString(obj[key]) );
+    }
+    return pairs.join('&');
+}
 
 
 /**
@@ -87,7 +111,7 @@ OAuthParams.prototype.normalize = function(){
 }    
 
 OAuthParams.prototype.serialize = function(){
-    return require('querystring').stringify( this.args );
+    return uriEncodeParams( this.args );
 }
 
 OAuthParams.prototype.sign = function( requestMethod, requestUri ){
@@ -99,8 +123,8 @@ OAuthParams.prototype.sign = function( requestMethod, requestUri ){
     delete this.args.oauth_signature;
     // normalize, build and sign
     this.normalize();
-    var str  = requestMethod.toUpperCase() +'&'+ encodeURIComponent(requestUri) +'&'+ encodeURIComponent(this.serialize()),
-        key  = encodeURIComponent(this.consumer_secret) +'&'+ encodeURIComponent(this.token_secret),
+    var str  = requestMethod.toUpperCase() +'&'+ uriEncodeString(requestUri) +'&'+ uriEncodeString(this.serialize()),
+        key  = uriEncodeString(this.consumer_secret) +'&'+ uriEncodeString(this.token_secret),
         hash = require('crypto').createHmac('sha1',key).update(str);
     this.args.oauth_signature = hash.digest('base64');
     return this;
@@ -309,6 +333,7 @@ TwitterClient.prototype._call = function( requestMethod, requestUri, requestArgs
         authHeader = params.getHeader();
     }
     var query = params.serialize();
+    
     // build http request starting with parsed endpoint
     var http = require('url').parse( requestUri );
     http.headers = {