nit: rename to clearer function paramters

Author: sachaservan

attestation/attestation.go

@@ -326,16 +326,16 @@ func Fetch(host string) (*Document, error) {
 	return &doc, nil
 }
 
-const defaultATCBaseURL = "https://atc.tinfoil.sh"
+const defaultAttestationBundleURL = "https://atc.tinfoil.sh"
 
-// FetchBundle retrieves a complete attestation bundle from the default ATC endpoint
+// FetchBundle retrieves a complete attestation bundle from the default endpoint
 func FetchBundle() (*Bundle, error) {
-	return FetchBundleFrom(defaultATCBaseURL)
+	return FetchBundleFrom(defaultAttestationBundleURL)
 }
 
-// FetchBundleFrom retrieves a complete attestation bundle from a custom ATC base URL
-func FetchBundleFrom(atcBaseURL string) (*Bundle, error) {
-	bundleURL := atcBaseURL + "/attestation"
+// FetchBundleFrom retrieves a complete attestation bundle from a custom base URL
+func FetchBundleFrom(attestationBundleURL string) (*Bundle, error) {
+	bundleURL := attestationBundleURL + "/attestation"
 
 	resp, _, err := util.Get(bundleURL)
 	if err != nil {

client/client.go

@@ -417,17 +417,17 @@ func VerifyFromATCJSON(repo string, sigstoreTrustedRootJSON []byte) (string, err
 	return VerifyFromATCURLJSON("", repo, sigstoreTrustedRootJSON)
 }
 
-// VerifyFromATCURLJSON fetches an attestation bundle from a custom ATC URL and verifies it.
-// If atcBaseURL is empty, defaults to https://atc.tinfoil.sh.
+// VerifyFromATCURLJSON fetches an attestation bundle from a custom URL and verifies it.
+// If attestationBundleURL is empty, defaults to https://atc.tinfoil.sh.
 // Returns the verification data as a JSON string.
-func VerifyFromATCURLJSON(atcBaseURL, repo string, sigstoreTrustedRootJSON []byte) (string, error) {
+func VerifyFromATCURLJSON(attestationBundleURL, repo string, sigstoreTrustedRootJSON []byte) (string, error) {
 	var bundle *attestation.Bundle
 	var err error
 
-	if atcBaseURL == "" {
+	if attestationBundleURL == "" {
 		bundle, err = attestation.FetchBundle()
 	} else {
-		bundle, err = attestation.FetchBundleFrom(atcBaseURL)
+		bundle, err = attestation.FetchBundleFrom(attestationBundleURL)
 	}
 	if err != nil {
 		return "", fmt.Errorf("failed to fetch bundle: %v", err)