Merge pull request #52 from tinify/feature/remove-get-with-body

fix: removed GET with body from result() call and replaced with POST …

Author: Sreini

CHANGES.md

@@ -1,5 +1,8 @@
-## 1.8.1
+## 1.8.2
+* Removed the `GET` with body HTTP call that was being made when obtaining the results of a compression and transforming at the same time. Replaced with `POST` in order to prepare for deprecation of `GET` with body interface from API.
+* Updated dependencies.
 
+## 1.8.1
 * Set minimum node engine to v14 in package.json
 * Update examples in README
 * Test the code on node 24

package.json

@@ -1,6 +1,6 @@
 {
   "name": "tinify",
-  "version": "1.8.1",
+  "version": "1.8.2",
   "description": "Node.js client for the Tinify API. Tinify compresses your images intelligently. Read more at https://tinify.com.",
   "keywords": [
     "tinify",
@@ -50,8 +50,8 @@
     "mocha": "^2.2.5",
     "nock": "^13.2.9",
     "semver": "*",
-    "tmp": "^0.0.26",
+    "tmp": "^0.2.4",
     "tslint": "^5.10.0",
     "typescript": "^5.7.3"
   }
-}
+}

src/tinify/Source.ts

@@ -77,7 +77,10 @@ export default class Source {
   result(): Result {
     const commands = this._commands
     const response = this._url.then(url => {
-      return tinify.client.request("get", url, commands)
+      if (Object.keys(commands).length > 0) {
+        return tinify.client.request("post", url, commands)
+      }
+      return tinify.client.request("get", url)
     })
 
     return new tinify.Result(

test/tinify-source-test.js

@@ -156,7 +156,7 @@ describe("Source", function() {
           .reply(201, {}, {location: "https://api.tinify.com/some/location"})
 
         nock("https://api.tinify.com")
-          .get("/some/location", '{"preserve":["copyright","location"]}')
+          .post("/some/location", '{"preserve":["copyright","location"]}')
           .reply(200, "copyrighted file")
       })
 
@@ -181,7 +181,7 @@ describe("Source", function() {
 
       it("should include other options if set", function() {
         nock("https://api.tinify.com")
-          .get("/some/location", '{"preserve":["copyright","location"],"resize":{"width":400}}')
+          .post("/some/location", '{"preserve":["copyright","location"],"resize":{"width":400}}')
           .reply(200, "copyrighted resized file")
 
         const data = tinify.Source.fromBuffer("png file").resize({width: 400}).preserve("copyright", "location").toBuffer()
@@ -198,7 +198,7 @@ describe("Source", function() {
           .reply(201, {}, {location: "https://api.tinify.com/some/location"})
 
         nock("https://api.tinify.com")
-          .get("/some/location", '{"resize":{"width":400}}')
+          .post("/some/location", '{"resize":{"width":400}}')
           .reply(200, "small file")
       })