Rename transcode to convert

Author: rkoopmans

test/integration.py

@@ -86,7 +86,7 @@ def test_should_preserve_metadata(self):
 
     def test_should_transcode_image(self):
         with create_named_tmpfile() as tmp:
-            a = self.optimized.transcode("image/webp").to_file(tmp)
+            a = self.optimized.convert(type=["image/webp"]).to_file(tmp)
             with open(tmp, 'rb') as f:
                 content = f.read()
 

test/tinify_source_test.py

@@ -56,8 +56,8 @@ def return_file(request, uri, headers):
             response = b'copyrighted file'
         elif 'resize' in data:
             response = b'small file'
-        elif 'type' in data:
-            response = b'transcoded file'
+        elif 'convert' in data:
+            response = b'converted file'
         elif 'transform' in data:
             response = b'transformed file'
         else:
@@ -137,13 +137,13 @@ def test_transform_should_return_source_with_data(self):
         self.assertEqual(b'transformed file', Source.from_buffer('png file').transform(background='black').to_buffer())
         self.assertJsonEqual('{"transform":{"background":"black"}}', httpretty.last_request().body.decode('utf-8'))
 
-    def test_transcode_should_return_source(self):
-        self.assertIsInstance(Source.from_buffer('png file').resize(width=400).transcode(['image/webp']), Source)
+    def test_convert_should_return_source(self):
+        self.assertIsInstance(Source.from_buffer('png file').resize(width=400).convert(type=['image/webp']), Source)
         self.assertEqual(b'png file', httpretty.last_request().body)
 
-    def test_transcode_should_return_source_with_data(self):
-        self.assertEqual(b'transcoded file', Source.from_buffer('png file').transcode('image/jpg').to_buffer())
-        self.assertJsonEqual('{"type": "image/jpg"}', httpretty.last_request().body.decode('utf-8'))
+    def test_convert_should_return_source_with_data(self):
+        self.assertEqual(b'converted file', Source.from_buffer('png file').convert(type='image/jpg').to_buffer())
+        self.assertJsonEqual('{"convert": {"type": "image/jpg"}}', httpretty.last_request().body.decode('utf-8'))
 
     def test_store_should_return_result_meta(self):
         self.assertIsInstance(Source.from_buffer('png file').store(service='s3'), ResultMeta)
@@ -176,9 +176,9 @@ def test_to_file_with_file_object_should_store_image_data(self):
     def test_all_options_together(self):
         self.assertEqual('https://bucket.s3-region.amazonaws.com/some/location',
                          Source.from_buffer('png file').resize(width=400)\
-                                                       .transcode(['image/webp', 'image/png'])\
+                                                       .convert(type=['image/webp', 'image/png'])\
                                                        .transform(background="black")\
                                                        .preserve("copyright", "location")\
                                                        .store(service='s3').location)
-        self.assertJsonEqual('{"store":{"service":"s3"},"resize":{"width":400},"preserve": ["copyright", "location"], "transform": {"background": "black"}, "type": ["image/webp", "image/png"]}', httpretty.last_request().body.decode('utf-8'))
+        self.assertJsonEqual('{"store":{"service":"s3"},"resize":{"width":400},"preserve": ["copyright", "location"], "transform": {"background": "black"}, "convert": {"type": ["image/webp", "image/png"]}}', httpretty.last_request().body.decode('utf-8'))
 

tinify/source.py

@@ -36,8 +36,8 @@ def preserve(self, *options):
     def resize(self, **options):
         return type(self)(self.url, **self._merge_commands(resize=options))
 
-    def transcode(self, types):
-        return type(self)(self.url, **self._merge_commands(type=types))
+    def convert(self, **options):
+        return type(self)(self.url, **self._merge_commands(convert=options))
 
     def transform(self, **options):
         return type(self)(self.url, **self._merge_commands(transform=options))