More pytest and replace httpretty with requests-mock

Author: rkoopmans

.github/workflows/ci-cd.yml

@@ -24,8 +24,7 @@ jobs:
       fail-fast: false
       matrix:
         python-version: [
-          "2.7",
-          "3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14-dev",
+          "3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14-dev",
           "pypy-2.7", "pypy-3.10"
         ]
         os: [ubuntu-latest, macOS-latest, windows-latest]

setup.py

@@ -10,8 +10,8 @@
 sys.path.insert(0, os.path.join(os.path.dirname(__file__), 'tinify'))
 from version import __version__
 
-install_require = ['requests >= 2.7.0, < 3.0.0']
-tests_require = ['pytest', 'httpretty < 1.1.5']
+install_require = ["requests >= 2.7.0, < 3.0.0"]
+tests_require = ["pytest", "pytest-xdist", "requests-mock"]
 
 if sys.version_info < (2, 7):
     tests_require.append('unittest2')

test/conftest.py

@@ -0,0 +1,32 @@
+import pytest
+import os
+import tinify
+import requests_mock
+
+
+@pytest.fixture
+def dummy_file():
+    return os.path.join(os.path.dirname(__file__), "examples", "dummy.png")
+
+
+@pytest.fixture(autouse=True)
+def reset_tinify():
+    original_key = tinify.key
+    original_app_identifier = tinify.app_identifier
+    original_proxy = tinify.proxy
+
+    tinify.key = None
+    tinify.app_identifier = None
+    tinify.proxy = None
+
+    yield
+
+    tinify.key = original_key
+    tinify.app_identifier = original_app_identifier
+    tinify.proxy = original_proxy
+
+
+@pytest.fixture
+def mock_requests():
+    with requests_mock.Mocker(real_http=False) as m:
+        yield m

test/helper.py

@@ -1,10 +1,14 @@
-import sys, os
+import sys
+import os
 from contextlib import contextmanager
-import tinify, unittest, tempfile
+import tinify
+import pytest
+import tempfile
 
 if not os.environ.get("TINIFY_KEY"):
     sys.exit("Set the TINIFY_KEY environment variable.")
 
+
 @contextmanager
 def create_named_tmpfile():
     #  Due to NamedTemporaryFile requiring to be closed when used on Windows
@@ -19,76 +23,87 @@ def create_named_tmpfile():
         os.unlink(tmp.name)
 
 
-class ClientIntegrationTest(unittest.TestCase):
+# Fixture for shared resources
+@pytest.fixture(scope="module")
+def optimized_image():
     tinify.key = os.environ.get("TINIFY_KEY")
     tinify.proxy = os.environ.get("TINIFY_PROXY")
 
-    unoptimized_path = os.path.join(os.path.dirname(__file__), 'examples', 'voormedia.png')
-    optimized = tinify.from_file(unoptimized_path)
+    unoptimized_path = os.path.join(
+        os.path.dirname(__file__), "examples", "voormedia.png"
+    )
+    return tinify.from_file(unoptimized_path)
+
+
+def test_should_compress_from_file(optimized_image):
+    with create_named_tmpfile() as tmp:
+        optimized_image.to_file(tmp)
+
+        size = os.path.getsize(tmp)
+
+        with open(tmp, "rb") as f:
+            contents = f.read()
+
+        assert 1000 < size < 1500
 
-    def test_should_compress_from_file(self):
-        with create_named_tmpfile() as tmp:
-            self.optimized.to_file(tmp)
+        # width == 137
+        assert b"\x00\x00\x00\x89" in contents
+        assert b"Copyright Voormedia" not in contents
 
-            size = os.path.getsize(tmp)
 
-            with open(tmp, 'rb') as f:
-                contents = f.read()
+def test_should_compress_from_url():
+    source = tinify.from_url(
+        "https://raw.githubusercontent.com/tinify/tinify-python/master/test/examples/voormedia.png"
+    )
+    with create_named_tmpfile() as tmp:
+        source.to_file(tmp)
 
-            self.assertTrue(1000 < size < 1500)
+        size = os.path.getsize(tmp)
+        with open(tmp, "rb") as f:
+            contents = f.read()
 
-            # width == 137
-            self.assertIn(b'\x00\x00\x00\x89', contents)
-            self.assertNotIn(b'Copyright Voormedia', contents)
+        assert 1000 < size < 1500
 
-    def test_should_compress_from_url(self):
-        source = tinify.from_url('https://raw.githubusercontent.com/tinify/tinify-python/master/test/examples/voormedia.png')
-        with create_named_tmpfile() as tmp:
-            source.to_file(tmp)
+        # width == 137
+        assert b"\x00\x00\x00\x89" in contents
+        assert b"Copyright Voormedia" not in contents
 
-            size = os.path.getsize(tmp)
-            with open(tmp, 'rb') as f:
-                contents = f.read()
 
-            self.assertTrue(1000 < size < 1500)
+def test_should_resize(optimized_image):
+    with create_named_tmpfile() as tmp:
+        optimized_image.resize(method="fit", width=50, height=20).to_file(tmp)
 
-            # width == 137
-            self.assertIn(b'\x00\x00\x00\x89', contents)
-            self.assertNotIn(b'Copyright Voormedia', contents)
+        size = os.path.getsize(tmp)
+        with open(tmp, "rb") as f:
+            contents = f.read()
 
-    def test_should_resize(self):
-        with create_named_tmpfile() as tmp:
-            self.optimized.resize(method="fit", width=50, height=20).to_file(tmp)
+        assert 500 < size < 1000
 
-            size = os.path.getsize(tmp)
-            with open(tmp, 'rb') as f:
-                contents = f.read()
+        # width == 50
+        assert b"\x00\x00\x00\x32" in contents
+        assert b"Copyright Voormedia" not in contents
 
-            self.assertTrue(500 < size < 1000)
 
-            # width == 50
-            self.assertIn(b'\x00\x00\x00\x32', contents)
-            self.assertNotIn(b'Copyright Voormedia', contents)
+def test_should_preserve_metadata(optimized_image):
+    with create_named_tmpfile() as tmp:
+        optimized_image.preserve("copyright", "creation").to_file(tmp)
 
-    def test_should_preserve_metadata(self):
-        with create_named_tmpfile() as tmp:
-            self.optimized.preserve("copyright", "creation").to_file(tmp)
+        size = os.path.getsize(tmp)
+        with open(tmp, "rb") as f:
+            contents = f.read()
 
-            size = os.path.getsize(tmp)
-            with open(tmp, 'rb') as f:
-                contents = f.read()
+        assert 1000 < size < 2000
 
-            self.assertTrue(1000 < size < 2000)
+        # width == 137
+        assert b"\x00\x00\x00\x89" in contents
+        assert b"Copyright Voormedia" in contents
 
-            # width == 137
-            self.assertIn(b'\x00\x00\x00\x89', contents)
-            self.assertIn(b'Copyright Voormedia', contents)
 
-    def test_should_transcode_image(self):
-        with create_named_tmpfile() as tmp:
-            a = self.optimized.convert(type=["image/webp"]).to_file(tmp)
-            with open(tmp, 'rb') as f:
-                content = f.read()
+def test_should_transcode_image(optimized_image):
+    with create_named_tmpfile() as tmp:
+        optimized_image.convert(type=["image/webp"]).to_file(tmp)
+        with open(tmp, "rb") as f:
+            content = f.read()
 
-            self.assertEqual(b'RIFF', content[:4])
-            self.assertEqual(b'WEBP', content[8:12])
+        assert b"RIFF" == content[:4]
+        assert b"WEBP" == content[8:12]