Skip to content

Commit 4c1fae5

Browse files
authored
chore: Remove redundant PropertySource from test framework (hiero-ledger#19358)
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
1 parent b8ee10a commit 4c1fae5

21 files changed

+66
-105
lines changed

hedera-node/test-clients/src/main/java/com/hedera/services/bdd/junit/hedera/AbstractLocalNode.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ protected AbstractLocalNode(@NonNull final NodeMetadata metadata) {
4141
@Override
4242
public @NonNull T initWorkingDir(@NonNull final String configTxt) {
4343
requireNonNull(configTxt);
44-
recreateWorkingDir(requireNonNull(metadata.workingDir()), configTxt);
44+
recreateWorkingDir(requireNonNull(metadata.workingDir()), configTxt, metadata.nodeId());
4545
workingDirInitialized = true;
4646
return self();
4747
}

hedera-node/test-clients/src/main/java/com/hedera/services/bdd/junit/hedera/utils/WorkingDirUtils.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ public class WorkingDirUtils {
8383

8484
private static final List<String> WORKING_DIR_DATA_FOLDERS = List.of(KEYS_FOLDER, CONFIG_FOLDER, UPGRADE_DIR);
8585

86+
private static final String LOG4J2_DATE_FORMAT = "%d{yyyy-MM-dd HH:mm:ss.SSS}";
87+
8688
private WorkingDirUtils() {
8789
throw new UnsupportedOperationException("Utility Class");
8890
}
@@ -109,7 +111,8 @@ public static Path workingDirFor(final long nodeId, @Nullable String scope) {
109111
* @param workingDir the path to the working directory
110112
* @param configTxt the contents of the <i>config.txt</i> file
111113
*/
112-
public static void recreateWorkingDir(@NonNull final Path workingDir, @NonNull final String configTxt) {
114+
public static void recreateWorkingDir(
115+
@NonNull final Path workingDir, @NonNull final String configTxt, final long nodeId) {
113116
requireNonNull(workingDir);
114117
requireNonNull(configTxt);
115118

@@ -130,7 +133,7 @@ public static void recreateWorkingDir(@NonNull final Path workingDir, @NonNull f
130133
// Copy the bootstrap assets into the working directory
131134
copyBootstrapAssets(bootstrapAssetsLoc(), workingDir);
132135
// Update the log4j2.xml file with the correct output directory
133-
updateLog4j2XmlOutputDir(workingDir);
136+
updateLog4j2XmlOutputDir(workingDir, nodeId);
134137
}
135138

136139
/**
@@ -195,7 +198,7 @@ private static Path bootstrapAssetsLoc() {
195198
: Path.of(TEST_CLIENTS_BOOTSTRAP_ASSETS_LOC);
196199
}
197200

198-
private static void updateLog4j2XmlOutputDir(@NonNull final Path workingDir) {
201+
private static void updateLog4j2XmlOutputDir(@NonNull final Path workingDir, long nodeId) {
199202
final var path = workingDir.resolve(LOG4J2_XML);
200203
final var log4j2Xml = readStringUnchecked(path);
201204
final var updatedLog4j2Xml = log4j2Xml
@@ -229,7 +232,9 @@ private static void updateLog4j2XmlOutputDir(@NonNull final Path workingDir) {
229232
\s""")
230233
.replace(
231234
"output/",
232-
workingDir.resolve(OUTPUT_DIR).toAbsolutePath().normalize() + "/");
235+
workingDir.resolve(OUTPUT_DIR).toAbsolutePath().normalize() + "/")
236+
// Differentiate between node outputs in combined logging
237+
.replace(LOG4J2_DATE_FORMAT, LOG4J2_DATE_FORMAT + " &lt;" + "n" + nodeId + "&gt;");
233238
writeStringUnchecked(path, updatedLog4j2Xml, StandardOpenOption.WRITE);
234239
}
235240

hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/HapiPropertySource.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -459,14 +459,6 @@ static ContractID asContract(String v) {
459459
.build();
460460
}
461461

462-
static ContractID asContractIdWithEvmAddress(ByteString address) {
463-
return ContractID.newBuilder()
464-
.setShardNum(getConfigShard())
465-
.setRealmNum(getConfigRealm())
466-
.setEvmAddress(address)
467-
.build();
468-
}
469-
470462
static String asContractString(ContractID contract) {
471463
return asEntityString(contract.getShardNum(), contract.getRealmNum(), contract.getContractNum());
472464
}

hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/PropertySource.java

Lines changed: 0 additions & 61 deletions
This file was deleted.

hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/queries/QueryUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// SPDX-License-Identifier: Apache-2.0
22
package com.hedera.services.bdd.spec.queries;
33

4-
import static com.hedera.services.bdd.spec.PropertySource.asAccountString;
4+
import static com.hedera.services.bdd.spec.HapiPropertySource.asAccountString;
55
import static com.hederahashgraph.api.proto.java.ResponseType.ANSWER_ONLY;
66
import static com.hederahashgraph.api.proto.java.ResponseType.COST_ANSWER;
77

hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/crypto/HapiCryptoUpdate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
// SPDX-License-Identifier: Apache-2.0
22
package com.hedera.services.bdd.spec.transactions.crypto;
33

4+
import static com.hedera.services.bdd.spec.HapiPropertySource.asAccountString;
45
import static com.hedera.services.bdd.spec.HapiPropertySource.asEntityString;
5-
import static com.hedera.services.bdd.spec.PropertySource.asAccountString;
66
import static com.hedera.services.bdd.spec.keys.SigMapGenerator.Nature.FULL_PREFIXES;
77
import static com.hedera.services.bdd.spec.queries.QueryVerbs.getAccountInfo;
88
import static com.hedera.services.bdd.spec.transactions.TxnUtils.*;

hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/token/HapiTokenAssociate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
package com.hedera.services.bdd.spec.transactions.token;
33

44
import static com.hedera.node.app.hapi.fees.usage.SingletonEstimatorUtils.ESTIMATOR_UTILS;
5-
import static com.hedera.services.bdd.spec.PropertySource.asAccountString;
5+
import static com.hedera.services.bdd.spec.HapiPropertySource.asAccountString;
66
import static com.hedera.services.bdd.spec.queries.QueryVerbs.getAccountInfo;
77
import static com.hedera.services.bdd.spec.queries.QueryVerbs.getContractInfo;
88
import static com.hedera.services.bdd.spec.transactions.TxnUtils.suFrom;

hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/token/HapiTokenDissociate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
package com.hedera.services.bdd.spec.transactions.token;
33

44
import static com.hedera.node.app.hapi.fees.usage.SingletonEstimatorUtils.ESTIMATOR_UTILS;
5-
import static com.hedera.services.bdd.spec.PropertySource.asAccountString;
5+
import static com.hedera.services.bdd.spec.HapiPropertySource.asAccountString;
66
import static com.hedera.services.bdd.spec.transactions.TxnUtils.suFrom;
77
import static java.util.stream.Collectors.toList;
88

hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/token/HapiTokenFreeze.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
package com.hedera.services.bdd.spec.transactions.token;
33

44
import static com.hedera.node.app.hapi.fees.usage.token.TokenOpsUsageUtils.TOKEN_OPS_USAGE_UTILS;
5-
import static com.hedera.services.bdd.spec.PropertySource.asAccountString;
5+
import static com.hedera.services.bdd.spec.HapiPropertySource.asAccountString;
66
import static com.hedera.services.bdd.spec.transactions.TxnUtils.suFrom;
77

88
import com.google.common.base.MoreObjects;

hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/token/HapiTokenKycGrant.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
package com.hedera.services.bdd.spec.transactions.token;
33

44
import static com.hedera.node.app.hapi.fees.usage.SingletonEstimatorUtils.ESTIMATOR_UTILS;
5-
import static com.hedera.services.bdd.spec.PropertySource.asAccountString;
5+
import static com.hedera.services.bdd.spec.HapiPropertySource.asAccountString;
66
import static com.hedera.services.bdd.spec.transactions.TxnUtils.suFrom;
77

88
import com.google.common.base.MoreObjects;

0 commit comments

Comments
 (0)