Fix linting for changes in Go >1.22:

No longer need to copy variables
in for loops.

Signed-off-by: Jacob Weinstock <[email protected]>

Author: jacobweinstock

.golangci.yml

@@ -13,7 +13,7 @@ linters:
     - errorlint
     - exhaustive
     #   - exhaustivestruct
-    - exportloopref
+    - copyloopvar
     - forbidigo
     - forcetypeassert
     - funlen

controller/machine/hardware.go

@@ -251,8 +251,6 @@ func byHardwareAffinity(hardware []tinkv1.Hardware, preferred []infrastructurev1
 	scores := map[client.ObjectKey]int32{}
 	// compute scores for each item based on the preferred term weights
 	for _, term := range preferred {
-		term := term
-
 		selector, err := metav1.LabelSelectorAsSelector(&term.HardwareAffinityTerm.LabelSelector)
 		if err != nil {
 			return nil, fmt.Errorf("constructing label selector: %w", err)

controller/machine/scope_test.go

@@ -84,8 +84,6 @@ func Test_Machine(t *testing.T) {
 	}
 
 	for name, c := range cases {
-		name, c := name, c
-
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			g := NewWithT(t)

controller/machine/template_test.go

@@ -76,8 +76,6 @@ func Test_Cloud_config_template(t *testing.T) {
 	}
 
 	for name, c := range cases {
-		c := c
-
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			g := NewWithT(t)