hook-bootkit: fix: last kernel cmdline option would have a newline (#265)

mergify[bot] · web-flow · commit 9c47c1ec7cc0 · 2025-04-16T17:19:47.000Z
Similar to #262 but for hook-bootkit.
diff --git a/images/hook-bootkit/main.go b/images/hook-bootkit/main.go
@@ -263,7 +263,7 @@ func removeTinkWorkerContainer(ctx context.Context, cli *client.Client) error {
 // https://github.com/tinkerbell/boots/blob/main/ipxe/hook.go
 func parseCmdLine(cmdLines []string) (cfg tinkWorkerConfig) {
 	for i := range cmdLines {
-		cmdLine := strings.SplitN(cmdLines[i], "=", 2)
+		cmdLine := strings.SplitN(strings.TrimSpace(cmdLines[i]), "=", 2)
 		if len(cmdLine) == 0 {
 			continue
 		}

Original file line number	Diff line number	Diff line change
`@@ -263,7 +263,7 @@ func removeTinkWorkerContainer(ctx context.Context, cli *client.Client) error {`
`263`	`263`	`// https://github.com/tinkerbell/boots/blob/main/ipxe/hook.go`
`264`	`264`	`func parseCmdLine(cmdLines []string) (cfg tinkWorkerConfig) {`
`265`	`265`	`for i := range cmdLines {`
`266`		`- cmdLine := strings.SplitN(cmdLines[i], "=", 2)`
	`266`	`+ cmdLine := strings.SplitN(strings.TrimSpace(cmdLines[i]), "=", 2)`
`267`	`267`	`if len(cmdLine) == 0 {`
`268`	`268`	`continue`
`269`	`269`	`}`