tf: Run setup.sh using remote-exec provisioner instead of userdata

This way we avoid a race condition where remote-exec is run before setup.sh
has finished running. This can happen because the provisioners are blocked
until the provision is complete, but userdata scripts run after the provisions
have been marked complete. So depending on how long it takes to create and
push the compose.tar.gz tarball we can be trying to execute docker-compose
commands before the files have been extracted.

This also has the added benefit that output from the execution of setup.sh
is visible when running terraform apply.

Signed-off-by: Manuel Mendez <[email protected]>

Author: mmlb

deploy/terraform/main.tf

@@ -62,7 +62,6 @@ resource "metal_device" "tink_provisioner" {
   operating_system = "ubuntu_20_04"
   billing_cycle    = "hourly"
   project_id       = var.project_id
-  user_data        = file("setup.sh")
 }
 
 resource "metal_device_network_type" "tink_provisioner_network_type" {
@@ -99,12 +98,22 @@ resource "null_resource" "setup" {
     destination = "/root/compose.tar.gz"
   }
 
+  provisioner "file" {
+    source      = "setup.sh"
+    destination = "/tmp/setup.sh"
+  }
+
   provisioner "remote-exec" {
     inline = [
+      "echo '===== running setup.sh ====='",
+      "chmod +x /tmp/setup.sh && /tmp/setup.sh",
+      "echo '===== extracting compose tarball ====='",
       "tar -vxz -f /root/compose.tar.gz -C /root/sandbox",
+      "echo '===== setting up docker-compose .env overrides ====='",
       "echo TINKERBELL_CLIENT_MAC=${local.worker_macs[0]} >>/root/sandbox/compose/.env",
       "echo TINKERBELL_TEMPLATE_MANIFEST=/manifests/template/ubuntu-equinix-metal.yaml >>/root/sandbox/compose/.env",
       "echo TINKERBELL_HARDWARE_MANIFEST=/manifests/hardware/hardware-equinix-metal.json >>/root/sandbox/compose/.env",
+      "echo '===== bringing up docker-compose stack ====='",
       "docker-compose -f /root/sandbox/compose/docker-compose.yml up -d"
     ]
   }