Skip to content

Commit dda633c

Browse files
committed
fix: incorrect bundle name on macOS due to project name changed in wails.json
1 parent 6968f74 commit dda633c

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

.github/workflows/release-macos.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ jobs:
102102
shell: bash
103103
working-directory: ./build
104104
run: |
105+
mv bin/tinyrdm.app "bin/Tiny RDM.app"
105106
./create-dmg/create-dmg \
106107
--no-internet-enable \
107108
--volname "Tiny RDM" \

.github/workflows/release-windows.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,11 +113,11 @@ jobs:
113113
Set-Content -Path certificate\certificate.txt -Value '${{ secrets.WIN_SIGNING_CERT }}'
114114
certutil -decode certificate\certificate.txt certificate\certificate.pfx
115115
echo "Signing TinyRDM installer"
116-
& 'C:/Program Files (x86)/Windows Kits/10/bin/10.0.17763.0/x86/signtool.exe' sign /td sha256 /tr http://timestamp.sectigo.com/?td=sha256 /f certificate\certificate.pfx /p '${{ secrets.WIN_SIGNING_CERT_PASSWORD }}' 'Tiny RDM-${{ steps.normalise_platform_name.outputs.pname }}-installer.exe'
116+
& 'C:/Program Files (x86)/Windows Kits/10/bin/10.0.17763.0/x86/signtool.exe' sign /td sha256 /tr http://timestamp.sectigo.com/?td=sha256 /f certificate\certificate.pfx /p '${{ secrets.WIN_SIGNING_CERT_PASSWORD }}' 'TinyRDM-${{ steps.normalise_platform_name.outputs.pname }}-installer.exe'
117117
118118
- name: Rename installer
119119
working-directory: ./build/bin
120-
run: Rename-Item -Path "Tiny RDM-${{ steps.normalise_platform_name.outputs.pname }}-installer.exe" -NewName "TinyRDM_Setup_${{ steps.normalise_version.outputs.version }}_${{ steps.normalise_platform.outputs.tag }}.exe"
120+
run: Rename-Item -Path "TinyRDM-${{ steps.normalise_platform_name.outputs.pname }}-installer.exe" -NewName "TinyRDM_Setup_${{ steps.normalise_version.outputs.version }}_${{ steps.normalise_platform.outputs.tag }}.exe"
121121

122122
- name: Upload release asset (Installer)
123123
uses: softprops/action-gh-release@v1

build/darwin/Info.dev.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<key>CFBundleName</key>
77
<string>{{.Info.ProductName}}</string>
88
<key>CFBundleExecutable</key>
9-
<string>{{.Name}}</string>
9+
<string>{{.Info.ProductName}}</string>
1010
<key>CFBundleIdentifier</key>
1111
<string>com.tinycraft.{{.Name}}</string>
1212
<key>CFBundleVersion</key>

build/darwin/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<key>CFBundleName</key>
77
<string>{{.Info.ProductName}}</string>
88
<key>CFBundleExecutable</key>
9-
<string>{{.Name}}</string>
9+
<string>{{.Info.ProductName}}</string>
1010
<key>CFBundleIdentifier</key>
1111
<string>com.tinycraft.{{.Name}}</string>
1212
<key>CFBundleVersion</key>

wails.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"$schema": "https://wails.io/schemas/config.v2.json",
3-
"name": "Tiny RDM",
3+
"name": "tinyrdm",
44
"outputfilename": "Tiny RDM",
55
"frontend:install": "npm install",
66
"frontend:build": "npm run build",

0 commit comments

Comments
 (0)