Fix DrawFastHLine for ST77xx, SSD1331 and SSD1351

droid42 · conejoninja · commit c3f3af5ffa9a · 2020-05-16T18:54:41.000+02:00
DrawFastHLine uses FillRectangle(x,y,width,height,c), so height must be 1 to draw a horizontal line
diff --git a/ssd1331/ssd1331.go b/ssd1331/ssd1331.go
@@ -220,7 +220,7 @@ func (d *Device) DrawFastHLine(x0, x1, y int16, c color.RGBA) {
 	if x0 > x1 {
 		x0, x1 = x1, x0
 	}
-	d.FillRectangle(x0, y, x1-x0+1, y, c)
+	d.FillRectangle(x0, y, x1-x0+1, 1, c)
 }
 
 // FillScreen fills the screen with a given color
diff --git a/ssd1351/ssd1351.go b/ssd1351/ssd1351.go
@@ -251,7 +251,7 @@ func (d *Device) DrawFastHLine(x0, x1, y int16, c color.RGBA) {
 	if x0 > x1 {
 		x0, x1 = x1, x0
 	}
-	d.FillRectangle(x0, y, x1-x0+1, y, c)
+	d.FillRectangle(x0, y, x1-x0+1, 1, c)
 }
 
 // FillScreen fills the screen with a given color
diff --git a/st7735/st7735.go b/st7735/st7735.go
@@ -323,7 +323,7 @@ func (d *Device) DrawFastHLine(x0, x1, y int16, c color.RGBA) {
 	if x0 > x1 {
 		x0, x1 = x1, x0
 	}
-	d.FillRectangle(x0, y, x1-x0+1, y, c)
+	d.FillRectangle(x0, y, x1-x0+1, 1, c)
 }
 
 // FillScreen fills the screen with a given color
diff --git a/st7789/st7789.go b/st7789/st7789.go
@@ -207,7 +207,7 @@ func (d *Device) DrawFastHLine(x0, x1, y int16, c color.RGBA) {
 	if x0 > x1 {
 		x0, x1 = x1, x0
 	}
-	d.FillRectangle(x0, y, x1-x0+1, y, c)
+	d.FillRectangle(x0, y, x1-x0+1, 1, c)
 }
 
 // FillScreen fills the screen with a given color

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,7 @@ func (d *Device) DrawFastHLine(x0, x1, y int16, c color.RGBA) {`
`220`	`220`	`if x0 > x1 {`
`221`	`221`	`x0, x1 = x1, x0`
`222`	`222`	`}`
`223`		`- d.FillRectangle(x0, y, x1-x0+1, y, c)`
	`223`	`+ d.FillRectangle(x0, y, x1-x0+1, 1, c)`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`// FillScreen fills the screen with a given color`
Original file line number	Diff line number	Diff line change
`@@ -251,7 +251,7 @@ func (d *Device) DrawFastHLine(x0, x1, y int16, c color.RGBA) {`
`251`	`251`	`if x0 > x1 {`
`252`	`252`	`x0, x1 = x1, x0`
`253`	`253`	`}`
`254`		`- d.FillRectangle(x0, y, x1-x0+1, y, c)`
	`254`	`+ d.FillRectangle(x0, y, x1-x0+1, 1, c)`
`255`	`255`	`}`
`256`	`256`
`257`	`257`	`// FillScreen fills the screen with a given color`
Original file line number	Diff line number	Diff line change
`@@ -323,7 +323,7 @@ func (d *Device) DrawFastHLine(x0, x1, y int16, c color.RGBA) {`
`323`	`323`	`if x0 > x1 {`
`324`	`324`	`x0, x1 = x1, x0`
`325`	`325`	`}`
`326`		`- d.FillRectangle(x0, y, x1-x0+1, y, c)`
	`326`	`+ d.FillRectangle(x0, y, x1-x0+1, 1, c)`
`327`	`327`	`}`
`328`	`328`
`329`	`329`	`// FillScreen fills the screen with a given color`
Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ func (d *Device) DrawFastHLine(x0, x1, y int16, c color.RGBA) {`
`207`	`207`	`if x0 > x1 {`
`208`	`208`	`x0, x1 = x1, x0`
`209`	`209`	`}`
`210`		`- d.FillRectangle(x0, y, x1-x0+1, y, c)`
	`210`	`+ d.FillRectangle(x0, y, x1-x0+1, 1, c)`
`211`	`211`	`}`
`212`	`212`
`213`	`213`	`// FillScreen fills the screen with a given color`