Apply review suggestions

suda · conejoninja · commit 0c0af6d3fef1 · 2020-02-18T23:34:56.000+01:00
diff --git a/src/machine/board_particle_argon.go b/src/machine/board_particle_argon.go
@@ -84,7 +84,7 @@ const (
 	ESP32_HOST_WK_PIN   Pin = 7
 )
 
-// Other periferals
+// Other peripherals
 const (
 	MODE_BUTTON_PIN   Pin = 11
 	CHARGE_STATUS_PIN Pin = 41
diff --git a/src/machine/board_particle_boron.go b/src/machine/board_particle_boron.go
@@ -78,19 +78,19 @@ const (
 	SPI1_HOLD_PIN Pin = 23
 )
 
-// u-blox coprocessor
+// u-blox SARA coprocessor
 const (
-	UBLOX_TXD_PIN      Pin = 37
-	UBLOX_RXD_PIN      Pin = 36
-	UBLOX_CTS_PIN      Pin = 38
-	UBLOX_RTS_PIN      Pin = 39
-	UBLOX_RESET_PIN    Pin = 12
-	UBLOX_POWER_ON_PIN Pin = 16
-	UBLOX_BUFF_EN_PIN  Pin = 25
-	UBLOX_VINT_PIN     Pin = 2
+	SARA_TXD_PIN      Pin = 37
+	SARA_RXD_PIN      Pin = 36
+	SARA_CTS_PIN      Pin = 38
+	SARA_RTS_PIN      Pin = 39
+	SARA_RESET_PIN    Pin = 12
+	SARA_POWER_ON_PIN Pin = 16
+	SARA_BUFF_EN_PIN  Pin = 25
+	SARA_VINT_PIN     Pin = 2
 )
 
-// Other periferals
+// Other peripherals
 const (
 	MODE_BUTTON_PIN Pin = 11
 	ANTENNA_SEL_PIN Pin = 7 // Low: chip antenna, High: External uFL
diff --git a/src/machine/board_particle_xenon.go b/src/machine/board_particle_xenon.go
@@ -73,7 +73,7 @@ const (
 	SPI1_HOLD_PIN Pin = 23
 )
 
-// Other periferals
+// Other peripherals
 const (
 	MODE_BUTTON_PIN   Pin = 11
 	CHARGE_STATUS_PIN Pin = 41
diff --git a/targets/particle-argon.json b/targets/particle-argon.json
@@ -1,6 +1,4 @@
 {
 	"inherits": ["particle-3rd-gen"],
-	"build-tags": ["particle_argon"],
-	"flash-method": "openocd",
-	"openocd-interface": "cmsis-dap"
+	"build-tags": ["particle_argon"]
 }
diff --git a/targets/particle-boron.json b/targets/particle-boron.json
@@ -1,6 +1,4 @@
 {
 	"inherits": ["particle-3rd-gen"],
-	"build-tags": ["particle_boron"],
-	"flash-method": "openocd",
-	"openocd-interface": "cmsis-dap"
+	"build-tags": ["particle_boron"]
 }
diff --git a/targets/particle-xenon.json b/targets/particle-xenon.json
@@ -1,6 +1,4 @@
 {
 	"inherits": ["particle-3rd-gen"],
-	"build-tags": ["particle_xenon"],
-	"flash-method": "openocd",
-	"openocd-interface": "cmsis-dap"
+	"build-tags": ["particle_xenon"]
 }

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ const (`
`84`	`84`	`ESP32_HOST_WK_PIN Pin = 7`
`85`	`85`	`)`
`86`	`86`
`87`		`-// Other periferals`
	`87`	`+// Other peripherals`
`88`	`88`	`const (`
`89`	`89`	`MODE_BUTTON_PIN Pin = 11`
`90`	`90`	`CHARGE_STATUS_PIN Pin = 41`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ const (`
`73`	`73`	`SPI1_HOLD_PIN Pin = 23`
`74`	`74`	`)`
`75`	`75`
`76`		`-// Other periferals`
	`76`	`+// Other peripherals`
`77`	`77`	`const (`
`78`	`78`	`MODE_BUTTON_PIN Pin = 11`
`79`	`79`	`CHARGE_STATUS_PIN Pin = 41`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,4 @@`
`1`	`1`	`{`
`2`	`2`	`"inherits": ["particle-3rd-gen"],`
`3`		`- "build-tags": ["particle_argon"],`
`4`		`- "flash-method": "openocd",`
`5`		`- "openocd-interface": "cmsis-dap"`
	`3`	`+ "build-tags": ["particle_argon"]`
`6`	`4`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,4 @@`
`1`	`1`	`{`
`2`	`2`	`"inherits": ["particle-3rd-gen"],`
`3`		`- "build-tags": ["particle_boron"],`
`4`		`- "flash-method": "openocd",`
`5`		`- "openocd-interface": "cmsis-dap"`
	`3`	`+ "build-tags": ["particle_boron"]`
`6`	`4`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,4 @@`
`1`	`1`	`{`
`2`	`2`	`"inherits": ["particle-3rd-gen"],`
`3`		`- "build-tags": ["particle_xenon"],`
`4`		`- "flash-method": "openocd",`
`5`		`- "openocd-interface": "cmsis-dap"`
	`3`	`+ "build-tags": ["particle_xenon"]`
`6`	`4`	`}`