Skip to content

Commit 25f6be1

Browse files
build: makes CI choose latest Go 1.18.x (#3143)
* build: makes CI choose latest Go 1.18.x
1 parent 9a9106a commit 25f6be1

File tree

4 files changed

+15
-8
lines changed

4 files changed

+15
-8
lines changed

.github/workflows/build-macos.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
- name: Install Go
3535
uses: actions/setup-go@v3
3636
with:
37-
go-version: '1.18.1'
37+
go-version: '1.18'
3838
cache: true
3939
- name: Cache LLVM source
4040
uses: actions/cache@v3

.github/workflows/linux.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ jobs:
118118
- name: Install Go
119119
uses: actions/setup-go@v3
120120
with:
121-
go-version: '1.18.1'
121+
go-version: '1.18'
122122
cache: true
123123
- name: Install wasmtime
124124
run: |
@@ -171,7 +171,7 @@ jobs:
171171
- name: Install Go
172172
uses: actions/setup-go@v3
173173
with:
174-
go-version: '1.18.1'
174+
go-version: '1.18'
175175
cache: true
176176
- name: Install Node.js
177177
uses: actions/setup-node@v2
@@ -271,7 +271,7 @@ jobs:
271271
- name: Install Go
272272
uses: actions/setup-go@v3
273273
with:
274-
go-version: '1.18.1'
274+
go-version: '1.18'
275275
cache: true
276276
- name: Cache LLVM source
277277
uses: actions/cache@v3
@@ -371,7 +371,7 @@ jobs:
371371
- name: Install Go
372372
uses: actions/setup-go@v3
373373
with:
374-
go-version: '1.18.1'
374+
go-version: '1.18'
375375
cache: true
376376
- name: Cache LLVM source
377377
uses: actions/cache@v3

.github/workflows/windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
- name: Install Go
3030
uses: actions/setup-go@v3
3131
with:
32-
go-version: '1.18.1'
32+
go-version: '1.18'
3333
cache: true
3434
- name: Cache LLVM source
3535
uses: actions/cache@v3

Makefile

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,6 @@ endif
330330
# compress/lzw appears to hang on wasi
331331
# crypto/hmac fails on wasi, it exits with a "slice out of range" panic
332332
# debug/plan9obj requires os.ReadAt, which is not yet supported on windows
333-
# io/fs requires os.ReadDir, which is not yet supported on windows or wasi
334333
# io/ioutil requires os.ReadDir, which is not yet supported on windows or wasi
335334
# strconv requires recover() which is not yet supported on wasi
336335
# text/template/parse requires recover(), which is not yet supported on wasi
@@ -344,7 +343,6 @@ TEST_PACKAGES_LINUX := \
344343
crypto/hmac \
345344
debug/dwarf \
346345
debug/plan9obj \
347-
io/fs \
348346
io/ioutil \
349347
strconv \
350348
testing/fstest \
@@ -373,19 +371,28 @@ report-stdlib-tests-pass:
373371
# Standard library packages that pass tests quickly on the current platform
374372
ifeq ($(shell uname),Darwin)
375373
TEST_PACKAGES_HOST := $(TEST_PACKAGES_FAST) $(TEST_PACKAGES_DARWIN)
374+
TEST_IOFS := true
376375
endif
377376
ifeq ($(shell uname),Linux)
378377
TEST_PACKAGES_HOST := $(TEST_PACKAGES_FAST) $(TEST_PACKAGES_LINUX)
378+
TEST_IOFS := true
379379
endif
380380
ifeq ($(OS),Windows_NT)
381381
TEST_PACKAGES_HOST := $(TEST_PACKAGES_FAST) $(TEST_PACKAGES_WINDOWS)
382+
TEST_IOFS := false
382383
endif
383384

384385
# Test known-working standard library packages.
385386
# TODO: parallelize, and only show failing tests (no implied -v flag).
386387
.PHONY: tinygo-test
387388
tinygo-test:
388389
$(TINYGO) test $(TEST_PACKAGES_HOST) $(TEST_PACKAGES_SLOW)
390+
@# io/fs requires os.ReadDir, not yet supported on windows or wasi. It also
391+
@# requires a large stack-size. Hence, io/fs is only run conditionally.
392+
@# For more details, see the comments on issue #3143.
393+
ifeq ($(TEST_IOFS),true)
394+
$(TINYGO) test -stack-size=6MB io/fs
395+
endif
389396
tinygo-test-fast:
390397
$(TINYGO) test $(TEST_PACKAGES_HOST)
391398
tinygo-bench:

0 commit comments

Comments
 (0)