compileopts: automatically add -g flag when including debug symbols

aykevl · deadprogram · commit 39433a3553cb · 2020-07-10T16:56:13.000+02:00
Debug information is often useful and there is no reason to include it
for Go code but not for C code. Also, disabling debug information should
disable it entirely, not just for Go code.
diff --git a/compileopts/config.go b/compileopts/config.go
@@ -176,6 +176,9 @@ func (c *Config) CFlags() []string {
 		cflags = append(cflags, "-nostdlibinc", "-Xclang", "-internal-isystem", "-Xclang", filepath.Join(root, "lib", "picolibc", "newlib", "libc", "include"))
 		cflags = append(cflags, "-I"+filepath.Join(root, "lib/picolibc-include"))
 	}
+	if c.Debug() {
+		cflags = append(cflags, "-g")
+	}
 	return cflags
 }
 
diff --git a/targets/gameboy-advance.json b/targets/gameboy-advance.json
@@ -9,7 +9,6 @@
 	"rtlib": "compiler-rt",
 	"libc": "picolibc",
 	"cflags": [
-		"-g",
 		"--target=arm4-none-eabi",
 		"-mcpu=arm7tdmi",
 		"-Oz",

Original file line number	Diff line number	Diff line change
`@@ -176,6 +176,9 @@ func (c *Config) CFlags() []string {`
`176`	`176`	`cflags = append(cflags, "-nostdlibinc", "-Xclang", "-internal-isystem", "-Xclang", filepath.Join(root, "lib", "picolibc", "newlib", "libc", "include"))`
`177`	`177`	`cflags = append(cflags, "-I"+filepath.Join(root, "lib/picolibc-include"))`
`178`	`178`	`}`
	`179`	`+ if c.Debug() {`
	`180`	`+ cflags = append(cflags, "-g")`
	`181`	`+ }`
`179`	`182`	`return cflags`
`180`	`183`	`}`
`181`	`184`