Skip to content

Commit 6611578

Browse files
aykevldeadprogram
authored andcommitted
compiler: remove some TODOs
These have long since been implemented.
1 parent d49a363 commit 6611578

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

compiler/compiler.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1403,7 +1403,6 @@ func (c *Compiler) parseExpr(frame *Frame, expr ssa.Value) (llvm.Value, error) {
14031403
// Size would be truncated if truncated to uintptr.
14041404
return llvm.Value{}, c.makeError(expr.Pos(), fmt.Sprintf("value is too big (%v bytes)", size))
14051405
}
1406-
// TODO: escape analysis
14071406
sizeValue := llvm.ConstInt(c.uintptrType, size, false)
14081407
buf := c.createRuntimeCall("alloc", []llvm.Value{sizeValue}, expr.Comment)
14091408
buf = c.builder.CreateBitCast(buf, llvm.PointerType(typ, 0), "")
@@ -1650,7 +1649,6 @@ func (c *Compiler) parseExpr(frame *Frame, expr ssa.Value) (llvm.Value, error) {
16501649
c.emitSliceBoundsCheck(frame, maxSize, sliceLen, sliceCap, expr.Len.Type().(*types.Basic), expr.Cap.Type().(*types.Basic))
16511650

16521651
// Allocate the backing array.
1653-
// TODO: escape analysis
16541652
sliceCapCast, err := c.parseConvert(expr.Cap.Type(), types.Typ[types.Uintptr], sliceCap, expr.Pos())
16551653
if err != nil {
16561654
return llvm.Value{}, err

0 commit comments

Comments
 (0)