Skip to content

Commit 6e1a40d

Browse files
committed
refactor: replace ConfigureUARTPin function with direct pin configuration in UART setup
1 parent ff3eff4 commit 6e1a40d

3 files changed

Lines changed: 8 additions & 10 deletions

File tree

src/machine/board_embedfire_py32f002b.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ const (
1919
)
2020

2121
func configureDefaultUARTPins() {
22-
ConfigureUARTPin(PA6, 1) // TX
23-
ConfigureUARTPin(PA7, 3) // RX
22+
PA6.Configure(PinConfig{Mode: PinAlternate})
23+
PA6.SetAltFunc(1)
24+
PA7.Configure(PinConfig{Mode: PinAlternate})
25+
PA7.SetAltFunc(3)
2426
}

src/machine/board_embedfire_py32f030.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ const (
1919
)
2020

2121
func configureDefaultUARTPins() {
22-
ConfigureUARTPin(PA7, 8) // TX
23-
ConfigureUARTPin(PA8, 8) // RX
22+
PA7.Configure(PinConfig{Mode: PinAlternate})
23+
PA7.SetAltFunc(8)
24+
PA8.Configure(PinConfig{Mode: PinAlternate})
25+
PA8.SetAltFunc(8)
2426
}

src/machine/machine_py32_uart.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,6 @@ func (uart *UART) Configure(config UARTConfig) error {
4949
return nil
5050
}
5151

52-
// Configure pin for use by UART
53-
func ConfigureUARTPin(pin Pin, af uint8) {
54-
pin.Configure(PinConfig{Mode: PinAlternate})
55-
pin.SetAltFunc(af)
56-
}
57-
5852
func handleUartInterrupt(interrupt.Interrupt) {
5953
uart := DefaultUART
6054
data := uint8(uart.Bus.DR.Get())

0 commit comments

Comments
 (0)