machine/atsamd51: fix obvious bug in I2C code

aykevl · deadprogram · commit bdfa4d28cfbb · 2020-01-20T21:33:53.000+01:00
I2C uses a hardcoded peripheral instead of referring to a specific
peripheral. In addition to that, it refers to the wrong SERCOM
(SERCOM3), which isn't used on any of the atsamd51 boards for I2C.
diff --git a/src/machine/machine_atsamd51.go b/src/machine/machine_atsamd51.go
@@ -1008,7 +1008,7 @@ func (i2c I2C) WriteByte(data byte) error {
 	timeout := i2cTimeout
 	for !i2c.Bus.INTFLAG.HasBits(sam.SERCOM_I2CM_INTFLAG_MB) {
 		// check for bus error
-		if sam.SERCOM3_I2CM.STATUS.HasBits(sam.SERCOM_I2CM_STATUS_BUSERR) {
+		if i2c.Bus.STATUS.HasBits(sam.SERCOM_I2CM_STATUS_BUSERR) {
 			return errors.New("I2C bus error")
 		}
 		timeout--

Original file line number	Diff line number	Diff line change
`@@ -1008,7 +1008,7 @@ func (i2c I2C) WriteByte(data byte) error {`
`1008`	`1008`	`timeout := i2cTimeout`
`1009`	`1009`	`for !i2c.Bus.INTFLAG.HasBits(sam.SERCOM_I2CM_INTFLAG_MB) {`
`1010`	`1010`	`// check for bus error`
`1011`		`- if sam.SERCOM3_I2CM.STATUS.HasBits(sam.SERCOM_I2CM_STATUS_BUSERR) {`
	`1011`	`+ if i2c.Bus.STATUS.HasBits(sam.SERCOM_I2CM_STATUS_BUSERR) {`
`1012`	`1012`	`return errors.New("I2C bus error")`
`1013`	`1013`	`}`
`1014`	`1014`	`timeout--`