fix(src/machine/nrf52xxx/adc): Register16.Get() already returns uint16, bit shifting does not make sense, <0 check neither

milkpirate · milkpirate · commit de4ef7a3e2fe · 2025-01-14T21:57:47.000+01:00
Signed-off-by: Paul Schroeder &lt;milkpirate@users.noreply.github.com&gt;
diff --git a/src/machine/machine_nrf52xxx.go b/src/machine/machine_nrf52xxx.go
@@ -169,13 +169,7 @@ func (a *ADC) Get() uint16 {
 	}
 	nrf.SAADC.EVENTS_STOPPED.Set(0)
 
-	value := int16(rawValue.Get())
-	if value < 0 {
-		value = 0
-	}
-
-	// Return 16-bit result from 12-bit value.
-	return uint16(value << 4)
+	return rawValue.Get()
 }
 
 // SPI on the NRF.

Original file line number	Diff line number	Diff line change
`@@ -169,13 +169,7 @@ func (a *ADC) Get() uint16 {`
`169`	`169`	`}`
`170`	`170`	`nrf.SAADC.EVENTS_STOPPED.Set(0)`
`171`	`171`
`172`		`- value := int16(rawValue.Get())`
`173`		`- if value < 0 {`
`174`		`- value = 0`
`175`		`- }`
`176`		`-`
`177`		`- // Return 16-bit result from 12-bit value.`
`178`		`- return uint16(value << 4)`
	`172`	`+ return rawValue.Get()`
`179`	`173`	`}`
`180`	`174`
`181`	`175`	`// SPI on the NRF.`