Ensure converted array is RO

Ben Krieger · Ben Krieger · commit e39191462521 · 2024-10-31T16:22:36.000-04:00
diff --git a/src/reflect/value.go b/src/reflect/value.go
@@ -78,7 +78,7 @@ func ValueOf(i interface{}) Value {
 		flags:    valueFlagExported,
 	}
 	if v.typecode.Kind() == Array && v.typecode.Size() > unsafe.Sizeof(uintptr(0)) {
-		v.flags |= valueFlagIndirect
+		v.flags |= valueFlagIndirect | valueFlagRO
 	}
 	return v
 }
@@ -1345,7 +1345,7 @@ func convertOp(src Value, typ Type) (Value, bool) {
 				return Value{
 					typecode: rtype,
 					value:    (*sliceHeader)(src.value).data,
-					flags:    src.flags | valueFlagIndirect,
+					flags:    src.flags | valueFlagIndirect | valueFlagRO,
 				}, true
 			}
 		case Pointer:

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ func ValueOf(i interface{}) Value {`
`78`	`78`	`flags: valueFlagExported,`
`79`	`79`	`}`
`80`	`80`	`if v.typecode.Kind() == Array && v.typecode.Size() > unsafe.Sizeof(uintptr(0)) {`
`81`		`- v.flags \|= valueFlagIndirect`
	`81`	`+ v.flags \|= valueFlagIndirect \| valueFlagRO`
`82`	`82`	`}`
`83`	`83`	`return v`
`84`	`84`	`}`
`@@ -1345,7 +1345,7 @@ func convertOp(src Value, typ Type) (Value, bool) {`
`1345`	`1345`	`return Value{`
`1346`	`1346`	`typecode: rtype,`
`1347`	`1347`	`value: (*sliceHeader)(src.value).data,`
`1348`		`- flags: src.flags \| valueFlagIndirect,`
	`1348`	`+ flags: src.flags \| valueFlagIndirect \| valueFlagRO,`
`1349`	`1349`	`}, true`
`1350`	`1350`	`}`
`1351`	`1351`	`case Pointer:`