-
Notifications
You must be signed in to change notification settings - Fork 996
arm: make FPU configuration consistent #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What we need before we can enable the FPU (and actually make use of it):
|
|
PyPortal (atsamd51j20a) worked correctly with the binary in the CI results section of Azure Pipelines. Later, I'll try feather-m4 (atsamd51j19a) and wioterminal (atsamd51p19a). |
|
The feather-m4 (atsamd51j19a) also works. It works without changing the atsamd51j19a.json, is that as intended? |
|
@aykevl |
|
wioterminal (atsamd51p19a) also works. |
|
Please update this file too. @aykevl targets/atsamd51j19a.json {
"inherits": ["cortex-m4"],
"build-tags": ["atsamd51j19", "atsamd51", "sam"],
"cflags": [
"-Qunused-arguments"
],
"linkerscript": "targets/atsamd51.ld",
"extra-files": [
"src/device/sam/atsamd51j19a.s"
]
} |
Eventually we might want to start using the FPU, but the easy option right now is to simply disable it everywhere. Previously, it depended on whether Clang was built as part of TinyGo or it was an external binary. By setting the floating point mode explicitly, such inconsistencies are avoided. This commit creates a new cortex-m4 target which can be the central place for setting FPU-related settings across all Cortex-M4 chips.
|
I've updated the atsamd51j19a, the nrf52840, and the stm32f4 with the same changes. Somehow I missed those (this time I grepped for |
Eventually we might want to start using the FPU, but the easy option right now is to simply disable it everywhere. Previously, it depended on whether Clang was built as part of TinyGo or it was an external binary (but Go code compiled with TinyGo never used the FPU). By setting the floating point mode explicitly, such inconsistencies are avoided.
This commit creates a new cortex-m4 target which can be the central place for setting FPU-related settings across all Cortex-M4 chips.
Tested on the pca10040 and the ItsyBitsy-m4.