machine/itsybitsy-nrf52840: add support for Adafruit Itsybitsy nrf52840 #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
product page: https://www.adafruit.com/product/4481 |
sago35
reviewed
Jul 19, 2020
Member
sago35
left a comment
sago35
left a comment
There was a problem hiding this comment.
I checked the following.
- Makefile.
- Make sure I can build
- README.md
- Check the product page & URL
- src/machine/board_itsybitsy-nrf52840.go
- targets/itsybitsy-nrf52840.json
- targets/feather-nrf52840.json and targets/ Compare with circuitplay-bluefruit.json
…40 Express board Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
deadprogram
force-pushed
the
itsybitsy-nrf52840
branch
from
54e9290 to
21ade0c
Compare
aykevl
approved these changes
Aug 25, 2020
Member
aykevl
left a comment
aykevl
left a comment
There was a problem hiding this comment.
Looks good to me (but perhaps others want to take a look).
Member
Author
|
OK, now squash/merging. Thank you everyone for the help on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Adafruit Itsybitsy nrf52840 Express board.