Skip to content

runtime: remove Cond #4646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024
Merged

runtime: remove Cond #4646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 0 additions & 90 deletions src/runtime/cond.go
View file
Open in desktop

This file was deleted.

38 changes: 0 additions & 38 deletions src/runtime/cond_nosched.go
View file
Open in desktop

This file was deleted.

44 changes: 0 additions & 44 deletions testdata/goroutines.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package main

import (
"runtime"
"sync"
"time"
)
Expand Down Expand Up @@ -83,8 +82,6 @@ func main() {

testGoOnInterface(Foo(0))

testCond()

testIssue1790()

done := make(chan int)
Expand Down Expand Up @@ -172,47 +169,6 @@ func testGoOnBuiltins() {
}
}

func testCond() {
var cond runtime.Cond
go func() {
// Wait for the caller to wait on the cond.
time.Sleep(time.Millisecond)

// Notify the caller.
ok := cond.Notify()
if !ok {
panic("notification not sent")
}

// This notification will be buffered inside the cond.
ok = cond.Notify()
if !ok {
panic("notification not queued")
}

// This notification should fail, since there is already one buffered.
ok = cond.Notify()
if ok {
panic("notification double-sent")
}
}()

// Verify that the cond has no pending notifications.
ok := cond.Poll()
if ok {
panic("unexpected early notification")
}

// Wait for the goroutine spawned earlier to send a notification.
cond.Wait()

// The goroutine should have also queued a notification in the cond.
ok = cond.Poll()
if !ok {
panic("missing queued notification")
}
}

var once sync.Once

func testGoOnInterface(f Itf) {
Expand Down