runtime (wasm): scan the system stack #5112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves the system stack pointer into a global and uses it to scan. It should fix some use-after-free issues?
deadprogram
approved these changes
Dec 6, 2025
Member
deadprogram
left a comment
deadprogram
left a comment
There was a problem hiding this comment.
LGTM. @dgryski or anyone else WASM oriented have any feedback before merge?
dgryski
approved these changes
Dec 8, 2025
Member
dgryski
left a comment
dgryski
left a comment
There was a problem hiding this comment.
So I think this looks correct. My question is why didn't we see this before? (That is, why was the block comment incorrect?)
Member
I think that bug was masked by some other bugs. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves the system stack pointer into a global and uses it to scan. It should fix some use-after-free issues?