remove string comparison

Author: talentlessguy

.gitignore

@@ -43,4 +43,5 @@ typings/
 
 dist
 coverage
-coverage.lcov
+coverage.lcov
+.DS_Store

migration.md

@@ -17,8 +17,7 @@
 | `urlencoded()` `interpretNumericEntities` option | ✅          | ❌                                 |
 | `urlencoded()` `depth` option                    | ✅          | ❌                                 |
 
-\* The `type` option can be a string or a function. `milliparsec` does not
-depend on the `type-is` package and does not support wildcard MIME strings (for
-example `*/json`). It only does a simple string comparisong of the first part of
-the `Content-Type` header. Unlike body-parser, milliparsec does not set default
-`type` on parsers.
+\* The `type` option can only be a function. `milliparsec` does not depend on
+the `type-is` package and does not support wildcard MIME strings (for example
+`*/json`). Unlike body-parser, milliparsec does not set default `type` on
+parsers.

src/types.ts

@@ -22,7 +22,7 @@ export type ParserOptions<T extends Record<string, any> = Record<string, any>> =
   /**
    * Middleware content type
    */
-  type: string | ((req: IncomingMessage) => boolean)
+  type: (req: IncomingMessage) => boolean
 }> &
   T
 

src/utils.ts

@@ -3,8 +3,5 @@ import type { ParserOptions } from './types.js'
 
 export const hasBody = (method: string): boolean => ['POST', 'PUT', 'PATCH', 'DELETE'].includes(method)
 
-export const checkType = (req: IncomingMessage, type: ParserOptions['type']): boolean => {
-  if (typeof type === 'string') return type === req.headers['content-type']?.split(';')[0]
-  if (typeof type === 'function') return type(req)
-  return true
-}
+export const checkType = (req: IncomingMessage, type: ParserOptions['type']): boolean =>
+  typeof type === 'function' ? type(req) : true

test.ts

@@ -565,44 +565,6 @@ describe('Content-Type filtering', () => {
     }).expect(200, { hello: 'world' })
   })
 
-  it('matches with a specified MIME type', async () => {
-    const server = createServer(async (req: ReqWithBody, res) => {
-      await json({ type: 'application/json' })(req, res, (err) => err && console.log(err))
-
-      res.setHeader('Content-Type', 'application/json')
-
-      res.end(JSON.stringify(req.body))
-    })
-
-    await makeFetch(server)('/', {
-      body: JSON.stringify({ hello: 'world' }),
-      method: 'POST',
-      headers: {
-        Accept: 'application/json',
-        'Content-Type': 'application/json'
-      }
-    }).expect(200, { hello: 'world' })
-  })
-
-  it('matches with a MIME + encoding type', async () => {
-    const server = createServer(async (req: ReqWithBody, res) => {
-      await json({ type: 'application/json' })(req, res, (err) => err && console.log(err))
-
-      res.setHeader('Content-Type', 'application/json; charset=utf-8')
-
-      res.end(JSON.stringify(req.body))
-    })
-
-    await makeFetch(server)('/', {
-      body: JSON.stringify({ hello: 'world' }),
-      method: 'POST',
-      headers: {
-        Accept: 'application/json',
-        'Content-Type': 'application/json; charset=utf-8'
-      }
-    }).expect(200, { hello: 'world' })
-  })
-
   it('executes the type(req) fn if type is a function', async () => {
     const server = createServer(async (req: ReqWithBody, res) => {
       await json({ type: (req) => req.headers['content-type'] === 'application/json' })(