bump order_approval version to 4

Author: etzellux

contracts/order/build/order_approval.teal

@@ -50,7 +50,7 @@
 // Versioning
 
 // Update this value by one with each new version
-#define VERSION 3
+#define VERSION 4
 
 
 // tl:85: router:
@@ -199,7 +199,7 @@ __func__create_application:
 
     // tl:119: app_global_put(VERSION_KEY, VERSION)
     pushbytes VERSION_KEY                                   // "version"
-    pushint VERSION                                         // 3
+    pushint VERSION                                         // 4
     app_global_put
 
     // create_application(user_address,registry_app_id,vault_app_id)
@@ -305,7 +305,7 @@ __func__post_update:
 
     // This will fail the update if the app is already at the same or higher version
     // tl:154: assert(VERSION > app_global_get(VERSION_KEY))
-    pushint VERSION                                         // 3
+    pushint VERSION                                         // 4
     pushbytes VERSION_KEY                                   // "version"
     app_global_get
     >
@@ -346,11 +346,11 @@ __func__post_update:
     // Always update the version number in global state
     // tl:170: app_global_put(VERSION_KEY, VERSION)
     pushbytes VERSION_KEY                                   // "version"
-    pushint VERSION                                         // 3
+    pushint VERSION                                         // 4
     app_global_put
     // tl:171: log(ARC28Event("post_update(uint64)", itob(VERSION)))
     pushbytes 0xfca63cfe                                    // SHA512_256("post_update(uint64)")[:4]
-    pushint VERSION                                         // 3
+    pushint VERSION                                         // 4
     itob
     concat
     log

contracts/order/build/order_approval.teal.tok

@@ -79,7 +79,7 @@ const int MINUTE = 60
 # Versioning
 
 # Update this value by one with each new version
-const int VERSION = 3
+const int VERSION = 4
 
 
 router:

contracts/order/order_approval.tl

@@ -30,4 +30,4 @@
 WEEK = DAY * 7
 MAX_UINT64 = 18446744073709551615
 
-CURRENT_VERSION = 3
+CURRENT_VERSION = 4

tests/constants.py

@@ -125,7 +125,7 @@ def create_order_app(self, app_id, app_creator_address):
             REGISTRY_APP_ACCOUNT_ADDRESS_KEY: decode_address(self.register_application_address),
             VAULT_APP_ID_KEY: self.vault_app_id,
             ROUTER_APP_ID_KEY: self.router_app_id,
-            VERSION_KEY: 1,
+            VERSION_KEY: CURRENT_VERSION,
         }
 
         # Register the app.

tests/core.py

@@ -80,15 +80,15 @@ def test_update_order_app(self):
         self.ordering_client = self.create_order_app(self.app_id, self.user_address)
         self.ledger.set_account_balance(self.ordering_client.application_address, 10_000_000)
 
-        self.assertEqual(self.ledger.get_global_state(self.app_id)[b"version"], 1)
+        self.assertEqual(self.ledger.get_global_state(self.app_id)[b"version"], CURRENT_VERSION)
 
         # Mock Approve a version
         approval_program = TealishProgram('contracts/order/order_approval.tl')
-        approval_program.tealish_source = approval_program.tealish_source.replace("VERSION = 1", "VERSION = 2")
+        approval_program.tealish_source = approval_program.tealish_source.replace(f"VERSION = {CURRENT_VERSION}", f"VERSION = {CURRENT_VERSION + 1}")
         approval_program.compile()
         update_bytecode = approval_program.bytecode
 
-        version = CURRENT_VERSION
+        version = CURRENT_VERSION + 1
         key = b"v" + version.to_bytes(8, "big")
         approval_hash = calculate_approval_hash(update_bytecode)
         struct = AppVersion()
@@ -109,16 +109,16 @@ def test_update_order_app(self):
         update_application_event = events[0]
 
         self.assertEqual(update_application_event["user_address"], self.user_address)
-        self.assertEqual(update_application_event["version"], CURRENT_VERSION)
+        self.assertEqual(update_application_event["version"], CURRENT_VERSION + 1)
 
         events = decode_logs(verify_update_txn[b'dt'][b'lg'], registry_events)
         emited_event = events[0]
 
         self.assertEqual(emited_event['event_name'], 'update_ordering_application')
         self.assertEqual(emited_event['order_app_id'], self.app_id)
-        self.assertEqual(emited_event['version'], CURRENT_VERSION)
+        self.assertEqual(emited_event['version'], CURRENT_VERSION + 1)
 
-        self.assertEqual(self.ledger.get_global_state(self.app_id)[b"version"], CURRENT_VERSION)
+        self.assertEqual(self.ledger.get_global_state(self.app_id)[b"version"], CURRENT_VERSION + 1)
 
 
 class PutTriggerOrderTests(OrderProtocolBaseTestCase):