Skip to content

Commit f11e533

Browse files
Apply suggestions from code review
Co-authored-by: tiny-ben-tran <[email protected]>
1 parent 66b672b commit f11e533

File tree

6 files changed

+14
-18
lines changed

6 files changed

+14
-18
lines changed

modules/ROOT/pages/8.3.0-release-notes.adoc

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,7 @@ include::partial$misc/admon-releasenotes-for-stable.adoc[]
2929

3030
{productname} {release-version} introduces the `+tinymce-premium+` NPM package, providing commercial customers with easy access to all premium plugins, skins, icons, and language packs directly from the NPM registry. The package is available for download at link:https://www.npmjs.com/package/tinymce-premium[https://www.npmjs.com/package/tinymce-premium].
3131

32-
The `+tinymce-premium+` package simplifies the installation and integration of premium plugins for projects using NPM or Yarn. The package includes all premium plugins, the license key manager plugin, and premium skins, icons, and language packs.
33-
34-
To get started with using premium plugins with {productname} using NPM, see: xref:npm-projects.adoc[Quick start: {productname} from NPM or Yarn].
32+
The `+tinymce-premium+` package simplifies the installation and integration of premium plugins. To get started with using premium plugins with {productname}, see: xref:npm-projects.adoc[Quick start: {productname} from NPM or Yarn].
3533

3634

3735
[[accompanying-premium-plugin-changes]]

modules/ROOT/pages/angular-pm-bundle.adoc

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
= Bundling TinyMCE with an Angular application
22
:navtitle: Using a package manager with bundling
3-
:description: A guide on bundling TinyMCE with an Angular application using a module loader.
4-
:keywords: integration, integrate, angular, bundle, webpack
3+
:description: A guide on bundling TinyMCE with an Angular application using Vite.
4+
:keywords: integration, integrate, angular, bundle, vite, npm, tinymce
55
:productSource: package-manager
66
:packageName: @tinymce/tinymce-angular
77

@@ -11,7 +11,7 @@ For examples of the {productname} Angular integration, visit https://tinymce.git
1111

1212
== Prerequisites
1313

14-
This procedure requires https://nodejs.org/[Node.js (and npm)].
14+
This procedure requires https://nodejs.org/[Node.js (and NPM)].
1515

1616
== Procedure
1717

@@ -54,7 +54,7 @@ For information on configuring premium plugins when bundling, see: xref:bundling
5454
import { Component } from '@angular/core';
5555
import { EditorComponent } from '@tinymce/tinymce-angular';
5656
57-
// TinyMCE so the global var exists
57+
// Ensure you import TinyMCE to register the global variable required by other components
5858
import 'tinymce/tinymce';
5959
// DOM model
6060
import 'tinymce/models/dom/model';
@@ -74,6 +74,7 @@ import 'tinymce/plugins/lists';
7474
import 'tinymce/plugins/table';
7575
import 'tinymce/plugins/code';
7676
import 'tinymce/plugins/help';
77+
import 'tinymce/plugins/help/js/en.js';
7778
import 'tinymce/plugins/wordcount';
7879
7980
include::partial$integrations/premium-plugins-bundling.adoc[]
@@ -96,7 +97,6 @@ import 'tinymce/skins/ui/oxide/content.js';
9697
export class MyEditorComponent {
9798
init: EditorComponent['init'] = {
9899
height: 500,
99-
menubar: false,
100100
plugins: 'advlist autolink lists link image table code help wordcount',
101101
toolbar: 'undo redo | blocks | bold italic | alignleft aligncenter alignright | bullist numlist | help'
102102
};
@@ -129,7 +129,6 @@ export class AppComponent {}
129129
ng serve
130130
----
131131
+
132-
The development server will automatically bundle your application, including TinyMCE, when you access it in your browser. The bundler processes all the `import` statements and includes the {productname} modules in the development bundle.
133132

134133
. Build the application for production:
135134
+
@@ -140,7 +139,7 @@ ng build
140139
+
141140
This command creates an optimized production bundle in the `+dist+` directory.
142141

143-
. Update the `+licenseKey+` option in the editor component and include your xref:license-key.adoc[License Key].
142+
. If premium plugins are included, update the `+licenseKey+` option in the editor component and include your xref:license-key.adoc[License Key].
144143

145144
== Next Steps
146145

modules/ROOT/pages/bundling-plugins.adoc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
== Overview
77

8-
{productname} plugins can be bundled using module loaders such as Webpack, Rollup, or Vite. This guide covers how to include both community and premium plugins in your application bundle.
8+
{productname} plugins can be bundled using a module bundler such as Webpack, Rollup, or Vite. This guide covers how to include both community and premium plugins in your application bundle.
99

1010
{productname} includes both community and premium plugins:
1111

@@ -151,10 +151,10 @@ tinymce.init({
151151
selector: 'textarea',
152152
license_key: 'T8LK:...', // Your commercial license key
153153
external_plugins: {
154-
'advcode': '<path_to_premium_plugins>/advcode/plugin.min.js',
155-
'tinycomments': '<path_to_premium_plugins>/tinycomments/plugin.min.js',
154+
'advcode': '/<path_to_premium_plugins>/advcode/plugin.min.js',
155+
'tinycomments': '/<path_to_premium_plugins>/tinycomments/plugin.min.js',
156156
// Always include the licensekeymanager plugin when using premium plugins with a commercial license.
157-
'licensekeymanager': '<path_to_premium_plugins>/licensekeymanager/plugin.min.js'
157+
'licensekeymanager': '/<path_to_premium_plugins>/licensekeymanager/plugin.min.js'
158158
},
159159
plugins: 'advcode tinycomments',
160160
// ... other configuration

modules/ROOT/pages/npm-projects.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ npm install tinymce-premium@^8.3
6262

6363
[NOTE]
6464
====
65-
The `+tinymce-premium+` package is available for {productname} 8.3 onwards and is currently only published to the NPM registry (Yarn can also install from NPM). The package version must align with the `+tinymce+` package version—always use compatible versions of both packages (e.g., both at 8.3.0 or later).
65+
The `+tinymce-premium+` package is available for {productname} 8.3 onwards and is currently only published to the NPM registry. The package version must align with the `+tinymce+` package version—always use compatible versions of both packages (e.g., both at 8.3.0 or later).
6666
====
6767

6868
=== Package contents
@@ -71,7 +71,7 @@ The `+tinymce-premium+` package includes:
7171

7272
* All premium plugins
7373
* License key manager plugin
74-
* Premium skins icons, and language packs for premium plugins
74+
* Premium skins, icons and language packs
7575

7676
[NOTE]
7777
====

modules/ROOT/pages/vue-pm-bundle.adoc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ export default {
134134
content: '<p>This is the initial content of the editor.</p>',
135135
editorConfig: {
136136
height: 500,
137-
menubar: false,
138137
plugins: 'advlist autolink lists link image table code help wordcount',
139138
toolbar: 'undo redo | blocks | bold italic | alignleft aligncenter alignright | bullist numlist | help'
140139
}

modules/ROOT/partials/configuration/external_plugins-premium-npm.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
=== Using premium plugins from NPM with `+external_plugins+`
1+
=== Using premium plugins from NPM with `+external_plugins+` option
22

33
When using the `+tinymce-premium+` package without bundling, you can configure premium plugins using the `+external_plugins+` option. The URLs can be specified in three ways:
44

0 commit comments

Comments
 (0)