Skip to content

Commit ffe29e0

Browse files
MitchC1999kemister85
MitchC1999
and
kemister85
authored
Apply suggestions from code review
Co-authored-by: Karl Kemister-Sheppard <[email protected]>
1 parent 3c95bde commit ffe29e0

File tree

4 files changed

+34
-36
lines changed

4 files changed

+34
-36
lines changed

‎modules/ROOT/examples/live-demos/comments-callback-with-mentions/index.html‎

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,32 @@
11
<textarea id="comments-callback">
2-
<h2>Welcome to Tiny Comments!</h2>
3-
<p>Please try out this demo of our Tiny Comments premium plugin.</p>
4-
<ol>
5-
<li>Highlight the content you want to comment on.</li>
6-
<li>Click the <em>Add Comment</em> icon in the toolbar.</li>
7-
<li>Type your comment into the text field at the bottom of the Comment sidebar.</li>
8-
<li>Click <strong>Comment</strong>.</li>
9-
</ol>
10-
<p>Your comment is <span class="mce-annotation tox-comment" data-mce-annotation-uid="mce-conversation_420304606321716900864126" data-mce-annotation="tinycomments">then</span> attached to the text, <span class="mce-annotation tox-comment" data-mce-annotation-uid="mce-conversation_19679600221621399703915" data-mce-annotation="tinycomments">exactly like this!</span></p>
11-
<p>If you want to take Tiny Comments for a test drive in your own environment, Tiny Comments is one of the premium plugins you can try for free for 14 days by signing up for a Tiny account. Make sure to check out our documentation as well.</p>
12-
<h2>A simple table to play with</h2>
13-
<table style="border-collapse: collapse; width: 100%;" border="1">
14-
<thead>
15-
<tr>
16-
<th>Product</th>
17-
<th>Value</th>
18-
</tr>
19-
</thead>
20-
<tbody>
21-
<tr>
22-
<td><a href="https://www.tiny.cloud/">Tiny Cloud</a></td>
23-
<td>The easiest and most reliable way to integrate powerful rich text editing into your application.</td>
24-
</tr>
25-
<tr>
26-
<td><a href="https://www.tiny.cloud/drive/">Tiny Drive</a></td>
27-
<td>Image and file management for TinyMCE in the cloud.</td>
28-
</tr>
29-
</tbody>
30-
</table>
31-
<p>Thanks for supporting TinyMCE! We hope it helps your users create great content.</p>
2+
<h2>Welcome to Tiny Comments!</h2>
3+
<p>Please try out this demo of our Tiny Comments premium plugin with @mentions support.</p>
4+
<ol>
5+
<li>Highlight the content you want to comment on.</li>
6+
<li>Click the <em>Add Comment</em> icon in the toolbar.</li>
7+
<li>Type your comment into the text field at the bottom of the Comment sidebar, and use <code>@</code> followed by a name to mention a collaborator.</li>
8+
<li>Click <strong>Comment</strong>.</li>
9+
</ol>
10+
<p>Your comment is <span class="mce-annotation tox-comment" data-mce-annotation-uid="mce-conversation_420304606321716900864126" data-mce-annotation="tinycomments">then</span> attached to the text, <span class="mce-annotation tox-comment" data-mce-annotation-uid="mce-conversation_19679600221621399703915" data-mce-annotation="tinycomments">exactly like this!</span> You can <span class="mymention" style="color: #1b1; background-color: #eee;" data-mention-id="juliecasper" data-mce-mentions-id="juliecasper">@Julie Casper</span> directly in your comments to notify them.</p>
11+
<p>If you want to take Tiny Comments for a test drive in your own environment, Tiny Comments is one of the premium plugins you can try for free for 14 days by signing up for a Tiny account. Make sure to check out our documentation as well.</p>
12+
<h2>A simple table to play with</h2>
13+
<table style="border-collapse: collapse; width: 100%;" border="1">
14+
<thead>
15+
<tr>
16+
<th>Product</th>
17+
<th>Value</th>
18+
</tr>
19+
</thead>
20+
<tbody>
21+
<tr>
22+
<td><a href="https://www.tiny.cloud/">Tiny Cloud</a></td>
23+
<td>The easiest and most reliable way to integrate powerful rich text editing into your application.</td>
24+
</tr>
25+
<tr>
26+
<td><a href="https://www.tiny.cloud/drive/">Tiny Drive</a></td>
27+
<td>Image and file management for TinyMCE in the cloud.</td>
28+
</tr>
29+
</tbody>
30+
</table>
31+
<p>Thanks for supporting TinyMCE! We hope it helps your users create great content.</p>
3232
</textarea>

‎modules/ROOT/examples/live-demos/comments-embedded-with-mentions/index.html‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
<div id="tiny-ui">
22
<textarea id="comments-embedded" style="width: 100%; height: 500px;">
33
<h2>Welcome to Tiny Comments!</h2>
4-
<p>Please try out this demo of our Tiny Comments premium plugin.</p>
4+
<p>Please try out this demo of our Tiny Comments premium plugin with @mentions support.</p>
55
<ol>
66
<li>Highlight the content you want to comment on.</li>
77
<li>Click the <em>Add Comment</em> icon in the toolbar.</li>
8-
<li>Type your comment into the text field at the bottom of the Comment sidebar.</li>
8+
<li>Type your comment into the text field at the bottom of the Comment sidebar, and use <code>@</code> followed by a name to mention a collaborator.</li>
99
<li>Click <strong>Comment</strong>.</li>
1010
</ol>
11-
<p>Your comment is <span class="mce-annotation tox-comment" data-mce-annotation-uid="mce-conversation_420304606321716900864126" data-mce-annotation="tinycomments">then</span> attached to the text, <span class="mce-annotation tox-comment" data-mce-annotation-uid="mce-conversation_19679600221621399703915" data-mce-annotation="tinycomments">exactly like this!</span></p>
11+
<p>Your comment is <span class="mce-annotation tox-comment" data-mce-annotation-uid="mce-conversation_420304606321716900864126" data-mce-annotation="tinycomments">then</span> attached to the text, <span class="mce-annotation tox-comment" data-mce-annotation-uid="mce-conversation_19679600221621399703915" data-mce-annotation="tinycomments">exactly like this!</span> You can <span class="mymention" style="color: #1b1; background-color: #eee;" data-mention-id="juliecasper" data-mce-mentions-id="juliecasper">@Julie Casper</span> directly in your comments to notify them.</p>
1212
<p>If you want to take Tiny Comments for a test drive in your own environment, Tiny Comments is one of the premium plugins you can try for free for 14 days by signing up for a Tiny account. Make sure to check out our documentation as well.</p>
1313
<h2>A simple table to play with</h2>
1414
<table style="border-collapse: collapse; width: 100%;" border="1">

‎modules/ROOT/pages/comments-with-mentions.adoc‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ include::partial$configuration/mentions_fetch.adoc[leveloffset=+1]
3535

3636
== Required Comments options in callback mode
3737

38-
When using callback mode, the Comments plugin requires callback functions for the following options:
39-
4038
When using callback mode, the {pluginname} plugin requires callback functions for the following options:
4139

4240
* xref:tinycomments_create[`+tinycomments_create+`]

‎modules/ROOT/partials/plugin-apis/comments-apis.adoc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ console.log(comments.getEventLog(
131131
132132
const eventLog = comments.getEventLog();
133133
const events = eventLog.events;
134-
const mentionedUsers = events.flatMap(({ mentionUids }) => mentionedUids);
134+
const mentionedUsers = events.flatMap(({ mentionedUids }) => mentionedUids);
135135
136136
let whoMentionedWho = {};
137137
events.forEach((event) => {

0 commit comments

Comments
 (0)