[indexes] Fix multi-slice index with sorting bug

Fixes #217

Author: jamesgpearce

src/indexes/index.ts

@@ -9,7 +9,12 @@ import type {
   createIndexes as createIndexesDecl,
 } from '../@types/indexes/index.d.ts';
 import type {GetCell, Store} from '../@types/store/index.d.ts';
-import {arrayIsSorted, arrayMap, arraySort} from '../common/array.ts';
+import {
+  arrayForEach,
+  arrayIsSorted,
+  arrayMap,
+  arraySort,
+} from '../common/array.ts';
 import {
   collDel,
   collForEach,
@@ -99,7 +104,7 @@ export const createIndexes = getCreateFunction((store: Store): Indexes => {
         change: () => void,
         changedSliceIds: IdMap<[Id | Ids | undefined, Id | Ids | undefined]>,
         changedSortKeys: IdMap<SortKey>,
-        sliceIds?: IdMap<Id | Ids>,
+        sliceIdOrIdsByRowId?: IdMap<Id | Ids>,
         sortKeys?: IdMap<SortKey>,
         force?: boolean,
       ) => {
@@ -150,8 +155,13 @@ export const createIndexes = getCreateFunction((store: Store): Indexes => {
             mapForEach(index, (sliceId) => setAdd(unsortedSlices, sliceId));
           } else {
             mapForEach(changedSortKeys, (rowId) =>
-              ifNotUndefined(mapGet(sliceIds, rowId), (sliceId) =>
-                setAdd(unsortedSlices, sliceId),
+              ifNotUndefined(
+                mapGet(sliceIdOrIdsByRowId, rowId),
+                (sliceIdOrIds) =>
+                  arrayForEach(
+                    isArray(sliceIdOrIds) ? sliceIdOrIds : [sliceIdOrIds],
+                    (sliceId) => setAdd(unsortedSlices, sliceId),
+                  ),
               ),
             );
           }

test/unit/core/other/indexes.test.ts

@@ -1771,6 +1771,26 @@ describe('Miscellaneous', () => {
     expect(store.getValues()).toEqual({});
   });
 
+  test('Sorted multi-slice index does not error', () => {
+    const store = createStore();
+    const indexes = createIndexes(store);
+
+    indexes.setIndexDefinition(
+      'i1',
+      't1',
+      (getCell) => (getCell('c1') + '').split(''),
+      (getCell) => (getCell('c1') + '').split('')[0],
+    );
+
+    store.setCell('t1', 'r1', 'c1', 'abc');
+    store.setCell('t1', 'r2', 'c1', 'abc');
+    store.setCell('t1', 'r1', 'c1', 'ab');
+    expect(store.getTables()).toEqual({t1: {r1: {c1: 'ab'}, r2: {c1: 'abc'}}});
+    expect(getIndexesObject(indexes)).toEqual({
+      i1: {a: ['r1', 'r2'], b: ['r1', 'r2'], c: ['r2']},
+    });
+  });
+
   test('bad sort key', () => {
     indexes.setIndexDefinition('i1', 't1', 'c2', 'c0');
     setCells();