[lint] Address new lint defaults

Author: jamesgpearce

gulpfile.mjs

@@ -88,7 +88,7 @@ const clearDir = async (dir = DIST_DIR) => {
 const makeDir = async (dir) => {
   try {
     await promises.mkdir(dir);
-  } catch (e) {}
+  } catch {}
 };
 
 const ensureDir = async (fileOrDirectory) => {
@@ -111,11 +111,11 @@ const forEachDeepFile = (dir, callback, extension = '') =>
 const forEachDirAndFile = (dir, dirCallback, fileCallback, extension = '') =>
   readdirSync(dir, {withFileTypes: true}).forEach((entry) => {
     const path = resolve(join(dir, entry.name));
-    entry.isDirectory()
-      ? dirCallback?.(path)
-      : path.endsWith(extension)
-        ? fileCallback?.(path)
-        : null;
+    if (entry.isDirectory()) {
+      dirCallback?.(path);
+    } else if (path.endsWith(extension)) {
+      fileCallback?.(path);
+    }
   });
 
 const copyWithReplace = async (src, [from, to], dst = src) => {
@@ -330,6 +330,7 @@ const lintCheckDocs = async (dir) => {
         'no-console': 0,
         'react/prop-types': 0,
         'react-hooks/rules-of-hooks': 0,
+        '@typescript-eslint/no-unused-expressions': 0,
         'max-len': [
           2,
           {code: 80, ignorePattern: '^(\\s+\\* )?((im|ex)ports?|// ->)\\W.*'},

src/@types/synchronizers/synchronizer-local/index.d.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-empty-object-type */
 /// synchronizer-local
 
 import type {Receive, Send, Synchronizer} from '../index.d.ts';

src/@types/synchronizers/synchronizer-local/with-schemas/index.d.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-empty-object-type */
 /// synchronizer-local
 
 import type {Receive, Send, Synchronizer} from '../../with-schemas/index.d.ts';

src/common/listeners.ts

@@ -222,13 +222,15 @@ export const getListenerFunctions = (
       ([listener, , path = [], pathGetters, extraArgsGetter]) => {
         const callWithIds = (...ids: Ids): any => {
           const index = size(ids);
-          index == size(path)
-            ? (listener as any)(thing, ...ids, ...extraArgsGetter(ids))
-            : isUndefined(path[index])
-              ? arrayForEach(pathGetters[index]?.(...ids) ?? [], (id) =>
-                  callWithIds(...ids, id),
-                )
-              : callWithIds(...ids, path[index] as Id);
+          if (index == size(path)) {
+            (listener as any)(thing, ...ids, ...extraArgsGetter(ids));
+          } else if (isUndefined(path[index])) {
+            arrayForEach(pathGetters[index]?.(...ids) ?? [], (id) =>
+              callWithIds(...ids, id),
+            );
+          } else {
+            callWithIds(...ids, path[index] as Id);
+          }
         };
         callWithIds();
       },

src/common/map.ts

@@ -75,7 +75,9 @@ export const mapToObj = <MapValue, ObjValue = MapValue>(
       const objValue = valueMapper
         ? valueMapper(mapValue, id)
         : (mapValue as any as ObjValue);
-      excludeObjValue?.(objValue) ? 0 : (obj[id] = objValue);
+      if (!excludeObjValue?.(objValue)) {
+        obj[id] = objValue;
+      }
     }
   });
   return obj;

src/common/other.ts

@@ -10,7 +10,9 @@ export const startInterval = (
   sec: number,
   immediate?: 1,
 ) => {
-  immediate && callback();
+  if (immediate) {
+    callback();
+  }
   return setInterval(callback, sec * 1000);
 };
 export const stopInterval = clearInterval;

src/persisters/index.ts

@@ -169,9 +169,11 @@ export const createCustomPersister = <
       await schedule(async () => {
         try {
           const content = await getPersisted();
-          isArray(content)
-            ? setContentOrChanges(content)
-            : errorNew(`Content is not an array ${content}`);
+          if (isArray(content)) {
+            setContentOrChanges(content);
+          } else {
+            errorNew(`Content is not an array ${content}`);
+          }
         } catch (error) {
           onIgnoredError?.(error);
           if (initialContent) {

src/persisters/persister-partykit-server/index.ts

@@ -147,20 +147,27 @@ const saveStore = async (
                     objToArray(row, async (cell, cellId) => {
                       const ids: [Id, Id, Id] = [tableId, rowId, cellId];
                       const key = constructStorageKey(storagePrefix, T, ...ids);
-                      isUndefined(cell)
-                        ? !initialSave &&
+                      if (isUndefined(cell)) {
+                        if (
+                          !initialSave &&
                           (await that.canDelCell(
                             ...ids,
                             requestOrConnection as Connection,
-                          )) &&
-                          arrayPush(keysToDel, key)
-                        : (await that.canSetCell(
-                            ...ids,
-                            cell,
-                            initialSave,
-                            requestOrConnection,
-                            await storage.get(key),
-                          )) && (keysToSet[key] = cell);
+                          ))
+                        ) {
+                          arrayPush(keysToDel, key);
+                        }
+                      } else if (
+                        await that.canSetCell(
+                          ...ids,
+                          cell,
+                          initialSave,
+                          requestOrConnection,
+                          await storage.get(key),
+                        )
+                      ) {
+                        keysToSet[key] = cell;
+                      }
                     }),
                   )),
             ),
@@ -171,20 +178,24 @@ const saveStore = async (
   await promiseAll(
     objToArray(changes[1], async (value, valueId) => {
       const key = storagePrefix + V + valueId;
-      isUndefined(value)
-        ? !initialSave &&
-          (await that.canDelValue(
-            valueId,
-            requestOrConnection as Connection,
-          )) &&
-          arrayPush(keysToDel, key)
-        : (await that.canSetValue(
-            valueId,
-            value,
-            initialSave,
-            requestOrConnection,
-            await storage.get(key),
-          )) && (keysToSet[key] = value);
+      if (isUndefined(value)) {
+        if (
+          !initialSave &&
+          (await that.canDelValue(valueId, requestOrConnection as Connection))
+        ) {
+          arrayPush(keysToDel, key);
+        }
+      } else if (
+        await that.canSetValue(
+          valueId,
+          value,
+          initialSave,
+          requestOrConnection,
+          await storage.get(key),
+        )
+      ) {
+        keysToSet[key] = value;
+      }
     }),
   );
 

src/store/index.ts

@@ -557,7 +557,11 @@ export const createStore: typeof createStoreDecl = (): Store => {
       cellIdsChanged(tableId, rowId, cellId, -1);
       mapSet(row, cellId);
     };
-    isUndefined(defaultCell) ? delCell(cellId) : mapForEach(row, delCell);
+    if (isUndefined(defaultCell)) {
+      delCell(cellId);
+    } else {
+      mapForEach(row, delCell);
+    }
     if (collIsEmpty(row)) {
       rowIdsChanged(tableId, rowId, -1);
       if (collIsEmpty(mapSet(table, rowId))) {

src/synchronizers/common.ts

@@ -14,9 +14,9 @@ export const ifPayloadValid = (
   then: (clientId: string, remainder: string) => void,
 ) => {
   const splitAt = payload.indexOf(MESSAGE_SEPARATOR);
-  splitAt !== -1
-    ? then(slice(payload, 0, splitAt), slice(payload, splitAt + 1))
-    : 0;
+  if (splitAt !== -1) {
+    then(slice(payload, 0, splitAt), slice(payload, splitAt + 1));
+  }
 };
 
 export const receivePayload = (payload: string, receive: Receive) =>