[powersync] Fix test mocks

Author: bndkt

src/persisters/persister-powersync.ts

@@ -23,18 +23,15 @@ export const createPowerSyncPersister = ((
       powerSync.execute(sql, args).then((result) => result.rows?._array ?? []),
     (listener: UpdateListener): AbortController => {
       const abortController = new AbortController();
-
       const onChange = powerSync.onChange({
         rawTableNames: true,
         signal: abortController.signal,
       });
-
       (async () => {
         for await (const update of onChange) {
           arrayMap(update.changedTables, listener);
         }
       })();
-
       return abortController;
     },
     (abortController: AbortController) => abortController.abort(),

test/unit/persisters/persister-sqlite-json.test.ts

@@ -296,7 +296,7 @@ describe.each(Object.entries(VARIANTS).slice(1, 2))(
         expect(store2.getContent()).toEqual([{t1: {r1: {c1: 1}}}, {v1: 1}]);
       });
 
-      test.only('autoSave1 & autoLoad2, complex transactions', async () => {
+      test('autoSave1 & autoLoad2, complex transactions', async () => {
         await persister1.startAutoSave();
         await persister2.startAutoLoad();
         store1

test/unit/persisters/persister-sqlite-tabular.test.ts

@@ -1476,6 +1476,7 @@ describe.each(Object.entries(VARIANTS))(
         expect(store2.getContent()).toEqual([{t1: {r1: {c1: 1}}}, {v1: 1}]);
       });
 
+      // FAILS
       test('autoSave1 & autoLoad2, complex transactions', async () => {
         await persister1.startAutoSave();
         await persister2.startAutoLoad();

test/unit/persisters/persisters.test.ts

@@ -713,6 +713,7 @@ describe.each([
     expect(persister.getStats()).toEqual({loads: 1, saves: 0});
   });
 
+  // FAILS
   test('autoLoads', async () => {
     await persistable.set(location, [{t1: {r1: {c1: 1}}}]);
     await persister.startAutoLoad();

test/unit/persisters/sqlite.ts

@@ -72,7 +72,6 @@ class WASQLitePowerSyncDatabaseOpenFactory {
     const instance: AbstractPowerSyncDatabase = {
       execute: (sql, args) =>
         new Promise((resolve, reject) => {
-          console.info('*** EXECUTE', sql, args);
           return db.all(sql, args, (error, rows: {[id: string]: any}[]) =>
             error
               ? reject(error)
@@ -93,38 +92,26 @@ class WASQLitePowerSyncDatabaseOpenFactory {
           db.close();
           resolve();
         }),
-      onChange: ({signal} = {}) => {
-        console.warn('*** ONCHANGE', signal?.aborted);
-        return {
-          async *[Symbol.asyncIterator]() {
-            if (signal?.aborted) {
-              return;
-            }
-
-            while (true) {
-              const nextChange = await new Promise<WatchOnChangeEvent>(
-                (resolve) => {
-                  const observer = (_: any, _2: any, tableName: string) => {
-                    db.off('change', observer);
-                    console.warn('*** CHANGE', {changedTables: [tableName]});
-                    resolve({changedTables: [tableName]});
-                  };
-
-                  signal?.addEventListener('abort', () => {
-                    db.off('change', observer);
-                  });
-
-                  db.on('change', observer);
-                },
-              );
-
-              yield nextChange;
-            }
-          },
-        };
-      },
+      onChange: ({signal} = {}) => ({
+        async *[Symbol.asyncIterator]() {
+          signal?.addEventListener('abort', () =>
+            db.removeAllListeners('change'),
+          );
+          while (!signal?.aborted) {
+            const nextChange = await new Promise<WatchOnChangeEvent>(
+              (resolve) => {
+                const observer = (_: any, _2: any, tableName: string) => {
+                  db.removeAllListeners('change');
+                  resolve({changedTables: [tableName]});
+                };
+                db.addListener('change', observer);
+              },
+            );
+            yield nextChange;
+          }
+        },
+      }),
     };
-
     return instance;
   }
 }
@@ -211,7 +198,6 @@ export const VARIANTS: {[name: string]: SqliteVariant<any>} = {
     (ps: AbstractPowerSyncDatabase, sql: string, args: any[] = []) =>
       ps.execute(sql, args).then((result) => result.rows?._array ?? []),
     (ps: AbstractPowerSyncDatabase) => ps.close(),
-    1000,
   ],
   sqlite3: [
     async (): Promise<Database> => new sqlite3.Database(':memory:'),