[tests] Metric/Index/Relationship events can't mutate store

Author: jamesgpearce

test/unit/indexes.test.ts

@@ -1757,6 +1757,19 @@ describe('Listens to SliceRowIds when sets', () => {
 });
 
 describe('Miscellaneous', () => {
+  test('Listener cannot mutate original store', () => {
+    const listener = jest.fn(() => {
+      store.setValue('mutated', true);
+    });
+    indexes.setIndexDefinition('i1', 't1', 'c1');
+    indexes.addSliceIdsListener('i1', listener);
+    store.setCell('t1', 'r1', 'c1', 1);
+    expect(listener).toHaveBeenCalledTimes(1);
+    expect(store.getTables()).toEqual({t1: {r1: {c1: 1}}});
+    expect(indexes.getSliceIds('i1')).toEqual(['1']);
+    expect(store.getValues()).toEqual({});
+  });
+
   test('bad sort key', () => {
     indexes.setIndexDefinition('i1', 't1', 'c2', 'c0');
     setCells();

test/unit/metrics.test.ts

@@ -579,6 +579,19 @@ describe('Listens to Metrics when sets', () => {
 });
 
 describe('Miscellaneous', () => {
+  test('Listener cannot mutate original store', () => {
+    const listener = jest.fn(() => {
+      store.setValue('mutated', true);
+    });
+    metrics.setMetricDefinition('m1', 't1');
+    metrics.addMetricListener('m1', listener);
+    store.setCell('t1', 'r1', 'c1', 1);
+    expect(listener).toHaveBeenCalledTimes(1);
+    expect(store.getTables()).toEqual({t1: {r1: {c1: 1}}});
+    expect(metrics.getMetric('m1')).toEqual(1);
+    expect(store.getValues()).toEqual({});
+  });
+
   test('remove listener', () => {
     listener = createMetricsListener(metrics);
     const listenerId = listener.listenToMetric('/m1', 'm1');

test/unit/queries.test.ts

@@ -4266,11 +4266,13 @@ describe('Sorted Row Ids', () => {
 
 describe('Miscellaneous', () => {
   test('Listener cannot mutate original store', () => {
-    queries.setQueryDefinition('q1', 't1', ({select}) => select('c1'));
-    queries.addResultTableListener('q1', () => {
+    const listener = jest.fn(() => {
       store.setValue('mutated', true);
     });
+    queries.setQueryDefinition('q1', 't1', ({select}) => select('c1'));
+    queries.addResultTableListener('q1', listener);
     store.setCell('t1', 'r1', 'c1', 1);
+    expect(listener).toHaveBeenCalledTimes(1);
     expect(store.getTables()).toEqual({t1: {r1: {c1: 1}}});
     expect(queries.getResultTable('q1')).toEqual({r1: {c1: 1}});
     expect(store.getValues()).toEqual({});

test/unit/relationships.test.ts

@@ -724,6 +724,19 @@ describe('Linked lists', () => {
 });
 
 describe('Miscellaneous', () => {
+  test('Listener cannot mutate original store', () => {
+    const listener = jest.fn(() => {
+      store.setValue('mutated', true);
+    });
+    relationships.setRelationshipDefinition('r1', 't1', 't1', 'c1');
+    relationships.addRemoteRowIdListener('r1', 'r1', listener);
+    store.setCell('t1', 'r1', 'c1', 'r1');
+    expect(listener).toHaveBeenCalledTimes(1);
+    expect(store.getTables()).toEqual({t1: {r1: {c1: 'r1'}}});
+    expect(relationships.getRemoteRowId('r1', 'r1')).toEqual('r1');
+    expect(store.getValues()).toEqual({});
+  });
+
   test('remove listener', () => {
     listener = createRelationshipsListener(relationships);
     const listenerId = listener.listenToRemoteRowId('/r1/r1', 'r1', 'r1');