Skip to content

Commit 9b788fd

Browse files
authored
fix(eudic): ensure Eudic quick link icon is always shown when enabled (#960)
Removes the unreliable installation check for the Eudic application. Previously, the quick link icon would not appear for users with certain versions of Eudic due to an incomplete list of bundle IDs. This change fixes that issue by removing the check entirely. The icon will now always be displayed if the user enables it in the settings, leaving the responsibility of having the app installed to the user. The description for the corresponding setting has also been updated to remove the "(if installed)" text.
1 parent 9039aed commit 9b788fd

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

Easydict/App/Localizable.xcstrings

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8192,25 +8192,25 @@
81928192
"en" : {
81938193
"stringUnit" : {
81948194
"state" : "translated",
8195-
"value" : "Show Eudic quick link icon (if installed)"
8195+
"value" : "Show Eudic quick link icon"
81968196
}
81978197
},
81988198
"sk" : {
81998199
"stringUnit" : {
82008200
"state" : "translated",
8201-
"value" : "Zobraziť Eudic ikonu rýchleho odkazu (ak je nainštalovaný)"
8201+
"value" : "Zobraziť Eudic ikonu rýchleho odkazu"
82028202
}
82038203
},
82048204
"zh-Hans" : {
82058205
"stringUnit" : {
82068206
"state" : "translated",
8207-
"value" : "显示欧路词典快捷图标(若有安装)"
8207+
"value" : "显示欧路词典快捷图标"
82088208
}
82098209
},
82108210
"zh-Hant" : {
82118211
"stringUnit" : {
82128212
"state" : "translated",
8213-
"value" : "顯示歐路辭典快速連結圖示(如已安裝)"
8213+
"value" : "顯示歐路辭典快速連結圖示"
82148214
}
82158215
}
82168216
}

Easydict/objc/ViewController/View/Titlebar/EZTitlebar.m

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -326,11 +326,9 @@ - (void)setPin:(BOOL)pin {
326326

327327
// Eudic
328328
if (Configuration.shared.showEudicQuickLink) {
329-
// !!!: Note that some applications have multiple channel versions. Refer: https://github.com/tisfeng/Raycast-Easydict/issues/16
330-
BOOL installedEudic = [self checkInstalledApp:@[ @"com.eusoft.freeeudic", @"com.eusoft.eudic", @"eusoft.eudic.ip" ]];
331-
if (installedEudic) {
332-
[shortcutButtonTypes addObject:@(EZTitlebarButtonTypeEudicDic)];
333-
}
329+
// Fix https://github.com/tisfeng/Easydict/issues/957#issuecomment-3261505123
330+
// Since edudic has multiple bundle ids, we don't check if installed.
331+
[shortcutButtonTypes addObject:@(EZTitlebarButtonTypeEudicDic)];
334332
}
335333

336334
return shortcutButtonTypes.copy;

0 commit comments

Comments
 (0)