Skip to content

Commit 586f387

Browse files
jkbelcherandrewlook
authored andcommitted
Rename 2nd model texture from Index to Neighborhood (#773)
1 parent ce9e1f7 commit 586f387

File tree

5 files changed

+25
-22
lines changed

5 files changed

+25
-22
lines changed

te-app/src/main/java/titanicsend/ndi/NDIOutShader.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public class NDIOutShader extends GLShader implements GLShader.UniformSource {
3232
private String ndiStreamLabel = "TitanicsEnd";
3333

3434
private int modelCoordsTextureHandle = UNINITIALIZED;
35-
private int modelIndexTextureHandle = UNINITIALIZED;
35+
private int modelNeighborhoodTextureHandle = UNINITIALIZED;
3636

3737
// Variables that will be passed to uniforms
3838
// Incoming texture handle
@@ -199,7 +199,8 @@ public int getRenderTexture() {
199199
*/
200200
public void setModelCoordinates(LXModel model) {
201201
this.modelCoordsTextureHandle = this.glEngine.textureCache.getModelCoordsTexture(model);
202-
this.modelIndexTextureHandle = this.glEngine.textureCache.getModelIndexTexture(model);
202+
this.modelNeighborhoodTextureHandle =
203+
this.glEngine.textureCache.getModelNeighborhoodTexture(model);
203204
}
204205

205206
@Override

te-app/src/main/java/titanicsend/pattern/glengine/GLShader.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public abstract class GLShader {
5353
public static final int TEXTURE_UNIT_AUDIO = 0;
5454
public static final int TEXTURE_UNIT_MODEL_COORDS = 1;
5555
public static final int TEXTURE_UNIT_BACKBUFFER = 2;
56-
public static final int TEXTURE_UNIT_MODEL_INDEX = 3;
56+
public static final int TEXTURE_UNIT_MODEL_NEIGHBORHOOD = 3;
5757
public static final int FIRST_UNRESERVED_TEXTURE_UNIT = 4;
5858

5959
/**
@@ -218,7 +218,8 @@ public GLShader(Config config) {
218218
// Reserved texture units
219219
this.uniformTextureUnits.put(UniformNames.BACK_BUFFER, TEXTURE_UNIT_BACKBUFFER);
220220
this.uniformTextureUnits.put(UniformNames.LX_MODEL_COORDS, TEXTURE_UNIT_MODEL_COORDS);
221-
this.uniformTextureUnits.put(UniformNames.LX_MODEL_INDEX, TEXTURE_UNIT_MODEL_INDEX);
221+
this.uniformTextureUnits.put(
222+
UniformNames.LX_MODEL_NEIGHBORHOOD, TEXTURE_UNIT_MODEL_NEIGHBORHOOD);
222223
}
223224

224225
// Buffers

te-app/src/main/java/titanicsend/pattern/glengine/TEShader.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,15 @@ private class TextureInfo {
4343
// Render buffers: ping-pong FBOs and textures
4444
private PingPongFBO ppFBOs;
4545

46-
// Texture handle for the current view model coordinate texture
46+
// Texture handles for the current view model textures
4747
private int modelCoordsTextureHandle = UNINITIALIZED;
48-
private int modelIndexTextureHandle = UNINITIALIZED;
48+
private int modelNeighborhoodTextureHandle = UNINITIALIZED;
4949

5050
private static class TEShaderUniforms {
5151
private Uniform.Int1 audio;
5252
private Uniform.Int1 lxModelCoords;
5353
private Uniform.Int1 backBuffer;
54-
private Uniform.Int1 lxModelIndex;
54+
private Uniform.Int1 lxModelNeighborhood;
5555
}
5656

5757
private final TEShaderUniforms uniforms = new TEShaderUniforms();
@@ -140,7 +140,7 @@ private void initializeUniforms() {
140140
this.uniforms.audio = getUniformInt1(UniformNames.AUDIO_CHANNEL);
141141
this.uniforms.lxModelCoords = getUniformInt1(UniformNames.LX_MODEL_COORDS);
142142
this.uniforms.backBuffer = getUniformInt1(UniformNames.BACK_BUFFER);
143-
this.uniforms.lxModelIndex = getUniformInt1(UniformNames.LX_MODEL_INDEX);
143+
this.uniforms.lxModelNeighborhood = getUniformInt1(UniformNames.LX_MODEL_NEIGHBORHOOD);
144144
}
145145

146146
@Override
@@ -178,8 +178,8 @@ public void setUniforms(GLShader s) {
178178
bindTextureUnit(TEXTURE_UNIT_MODEL_COORDS, this.modelCoordsTextureHandle);
179179
this.uniforms.lxModelCoords.setValue(TEXTURE_UNIT_MODEL_COORDS);
180180

181-
bindTextureUnit(TEXTURE_UNIT_MODEL_INDEX, this.modelIndexTextureHandle);
182-
this.uniforms.lxModelIndex.setValue(TEXTURE_UNIT_MODEL_INDEX);
181+
bindTextureUnit(TEXTURE_UNIT_MODEL_NEIGHBORHOOD, this.modelNeighborhoodTextureHandle);
182+
this.uniforms.lxModelNeighborhood.setValue(TEXTURE_UNIT_MODEL_NEIGHBORHOOD);
183183

184184
// Clear backbuffer on first frame
185185
if (this.needsClearBackBuffer) {
@@ -272,7 +272,7 @@ protected void render() {
272272
public void unbindTextures() {
273273
// Unbind textures (except for audio, which stays bound for all patterns)
274274
unbindTextureUnit(TEXTURE_UNIT_MODEL_COORDS);
275-
unbindTextureUnit(TEXTURE_UNIT_MODEL_INDEX);
275+
unbindTextureUnit(TEXTURE_UNIT_MODEL_NEIGHBORHOOD);
276276
unbindTextureUnit(TEXTURE_UNIT_BACKBUFFER);
277277
for (TextureInfo ti : this.fileTextures) {
278278
unbindTextureUnit(ti.unit);
@@ -301,7 +301,8 @@ public void setCpuBuffer(int[] cpuBuffer) {
301301
*/
302302
public void setModel(LXModel model) {
303303
this.modelCoordsTextureHandle = this.glEngine.textureCache.getModelCoordsTexture(model);
304-
this.modelIndexTextureHandle = this.glEngine.textureCache.getModelIndexTexture(model);
304+
this.modelNeighborhoodTextureHandle =
305+
this.glEngine.textureCache.getModelNeighborhoodTexture(model);
305306
}
306307

307308
// Releases native resources allocated by this shader.

te-app/src/main/java/titanicsend/pattern/glengine/TextureManager.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import static com.jogamp.opengl.GL.GL_TEXTURE_WRAP_S;
1111
import static com.jogamp.opengl.GL.GL_TEXTURE_WRAP_T;
1212
import static titanicsend.pattern.glengine.GLShader.TEXTURE_UNIT_MODEL_COORDS;
13-
import static titanicsend.pattern.glengine.GLShader.TEXTURE_UNIT_MODEL_INDEX;
13+
import static titanicsend.pattern.glengine.GLShader.TEXTURE_UNIT_MODEL_NEIGHBORHOOD;
1414

1515
import com.jogamp.opengl.GL4;
1616
import com.jogamp.opengl.GLAutoDrawable;
@@ -125,8 +125,8 @@ public void createModelTextures(LXModel model) {
125125
ModelTexture[] slots = new ModelTexture[MODEL_TEXTURE_COUNT];
126126
ModelTexture normalizedXYZ = new ModelTexture();
127127
slots[0] = normalizedXYZ;
128-
ModelTexture indexMap = new ModelTexture();
129-
slots[1] = indexMap;
128+
ModelTexture neighborhood = new ModelTexture();
129+
slots[1] = neighborhood;
130130
this.modelTextures.put(model, slots);
131131

132132
// Double check size of engine and model points
@@ -190,15 +190,15 @@ public void createModelTextures(LXModel model) {
190190
gl4.glBindTexture(GL_TEXTURE_2D, 0);
191191
gl4.glActiveTexture(GL_TEXTURE0);
192192

193-
// And create an OpenGL texture to hold the index data
194-
this.glEngine.bindTextureUnit(TEXTURE_UNIT_MODEL_INDEX, indexMap.getHandle());
193+
// And create an OpenGL texture to hold the neighborhood data
194+
this.glEngine.bindTextureUnit(TEXTURE_UNIT_MODEL_NEIGHBORHOOD, neighborhood.getHandle());
195195

196196
gl4.glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
197197
gl4.glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
198198
gl4.glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
199199
gl4.glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
200200

201-
// load the index data into the texture
201+
// load the neighborhood data into the texture
202202
gl4.glTexImage2D(
203203
GL4.GL_TEXTURE_2D, 0, GL4.GL_RG32F, width, height, 0, GL4.GL_RG, GL4.GL_FLOAT, indices);
204204

@@ -225,7 +225,7 @@ private int getModelTexture(LXModel model, int textureUnit) {
225225
case TEXTURE_UNIT_MODEL_COORDS: // normalized coordinates
226226
tex = slots[0];
227227
break;
228-
case TEXTURE_UNIT_MODEL_INDEX: // textureUnit mapping
228+
case TEXTURE_UNIT_MODEL_NEIGHBORHOOD: // textureUnit mapping
229229
tex = slots[1];
230230
break;
231231
default:
@@ -265,11 +265,11 @@ public int getModelCoordsTexture(LXModel model) {
265265
* @param model The model (view) to copy coordinates from
266266
* @return The texture handle of the view's indices texture
267267
*/
268-
public int getModelIndexTexture(LXModel model) {
268+
public int getModelNeighborhoodTexture(LXModel model) {
269269
if (!hasModelTextures(model)) {
270270
createModelTextures(model);
271271
}
272-
return getModelTexture(model, TEXTURE_UNIT_MODEL_INDEX);
272+
return getModelTexture(model, TEXTURE_UNIT_MODEL_NEIGHBORHOOD);
273273
}
274274

275275
/**

te-app/src/main/java/titanicsend/pattern/yoffa/shader_engine/UniformNames.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ public class UniformNames {
99
public static final String AUDIO_CHANNEL = CHANNEL + "0";
1010
public static final String LX_PARAMETER_SUFFIX = "_parameter";
1111
public static final String LX_MODEL_COORDS = "lxModelCoords";
12-
public static final String LX_MODEL_INDEX = "lxModelIndex";
12+
public static final String LX_MODEL_NEIGHBORHOOD = "lxModelIndex";
1313
public static final String BACK_BUFFER = "iBackbuffer";
1414
}

0 commit comments

Comments
 (0)