Visual indicator on UserPresets knob when there are no presets (#778)

* Bug fix: suppress command engine with UIOffairParameter

* Visual indicator on UserPresets knob when there are no presets

* Use relative increment mode for OffAir parameters

---------

Co-authored-by: Will Drevo <worldveil@users.noreply.github.com>

Author: jkbelcher

te-app/src/main/java/titanicsend/model/justin/LXVirtualDiscreteParameter.java

@@ -57,13 +57,15 @@ public LXVirtualDiscreteParameter<T> setParameter(T parameter) {
   public LXVirtualDiscreteParameter<T> setParameter(T parameter, boolean fireImmediately) {
     if (this.parameter != null) {
       this.parameter.removeListener(realParameterListener);
+      this.parameter.optionsChanged.removeListener(this.realOptionsChangedListener);
       if (this.parameter instanceof DisposableParameter) {
         ((DisposableParameter) this.parameter).unlistenDispose(disposeParameterListener);
       }
     }
     this.parameter = parameter;
     if (this.parameter != null) {
       this.parameter.addListener(realParameterListener);
+      this.parameter.optionsChanged.addListener(this.realOptionsChangedListener);
       if (this.parameter instanceof DisposableParameter) {
         ((DisposableParameter) this.parameter).listenDispose(disposeParameterListener);
       }
@@ -79,6 +81,11 @@ public LXVirtualDiscreteParameter<T> setParameter(T parameter, boolean fireImmed
         onRealParameterChanged();
       };
 
+  private final LXParameterListener realOptionsChangedListener =
+      (p) -> {
+        onRealOptionsChanged();
+      };
+
   private final DisposeListener disposeParameterListener =
       (p) -> {
         onRealParameterDisposed();
@@ -88,8 +95,14 @@ protected void onRealParameterChanged() {
     bang();
   }
 
+  protected void onRealOptionsChanged() {
+    // Relay optionsChanged event
+    this.optionsChanged.bang();
+  }
+
   protected void onRealParameterDisposed() {
     this.parameter.removeListener(realParameterListener);
+    this.parameter.optionsChanged.removeListener(this.realOptionsChangedListener);
     this.parameter = null;
   }
 

te-app/src/main/java/titanicsend/parameter/OffairDiscreteParameter.java

@@ -18,6 +18,7 @@ public class OffairDiscreteParameter extends LXVirtualDiscreteParameter<Discrete
 
   public OffairDiscreteParameter(String label, DiscreteParameter parameter) {
     super(label, parameter);
+    this.setIncrementMode(IncrementMode.RELATIVE);
   }
 
   /**

te-app/src/main/java/titanicsend/parameter/UIOffairDiscreteParameter.java

@@ -3,6 +3,7 @@
 import heronarts.glx.ui.UI;
 import heronarts.glx.ui.component.UIKnob;
 import heronarts.lx.parameter.LXParameter;
+import heronarts.lx.parameter.LXParameterListener;
 import heronarts.lx.studio.ui.device.UIDeviceControls;
 
 public class UIOffairDiscreteParameter extends UIKnob
@@ -18,5 +19,13 @@ public UIOffairDiscreteParameter(
 
     // There's an issue when this wraps a preset selector. It needs to not use the command engine.
     setUseCommandEngine(false);
+
+    // For visual aid, disable if there is only one option
+    LXParameterListener optionsChangedListener =
+        (p) -> {
+          setEditable(parameter.getOptions().length > 1);
+          redraw();
+        };
+    addListener(parameter.optionsChanged, optionsChangedListener, true);
   }
 }