Update of `taglib` to version 2.x breaks build: `tizprobe.hpp:122:9: error: ‘TagLib::uint’ has not been declared`.

[dreirund]

Issue

Description

After update of taglib from version 1.13.1 to 2.0 build of tizonia fails with
tizprobe.hpp:122:9: error: ‘TagLib::uint’ has not been declared.

Steps to Reproduce

1. Build according to this recipe:

   git clone https://github.com/tizonia/tizonia-openmax-il.git
   
   wget -O fix_chromecast_placeholders_error.patch https://github.com/tizonia/tizonia-openmax-il/files/9795320/fix_chromecast_placeholders_error.patch.txt
   
   cd tizonia-openmax-il
   patch -N p1 -i ../fix_chromecast_placeholders_error.patch
   
   _no_cc_warnings=(
     'address'
     'attribute-warning'
     'deprecated-declarations'
     'format-security'
     'strict-aliasing'
     'unused-result'
   )
   _CFLAGSAPPEND=''
   for _no_cc_warn in "${_no_cc_warnings[@]}"; do
     _CFLAGSAPPEND+=" -Wno-error=${_no_cc_warn} -Wno-${_no_cc_warn}"
   done
   _CFLAGSAPPEND+=" -DBOOST_BIND_GLOBAL_PLACEHOLDERS=1"
   
   export CFLAGS="-march=native -mtune=native -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -fstack-clash-protection -fcf-protection ${_CFLAGSAPPEND}"
   export CXXFLAGS="${CFLAGS} -Wp,-D_GLIBCXX_ASSERTIONS"
   export SAMUFLAGS="-j1"
   
   meson setup --prefix=/usr --buildtype=plain \
     -Dplayer=true \
     -Dlibspotify=false \
     -Dalsa=true \
     -Daac=true \
     -Dgcc-warnings=false \
     -Dtest=false \
     -Dbashcompletiondir=/etc/bash_completion.d \
     -Dzshcompletiondir=/usr/share/zsh/site-functions \
     -Ddocs=true \
     -Ddocs_options='["man"]' \
     -Ddocs_paper=a4 \
     -Dclients=true \
     -Dplugins='["aac_decoder","chromecast_renderer","file_reader","file_writer","flac_decoder","http_renderer","http_source","inproc_reader","inproc_writer","mp3_decoder","mp3_encoder","mp3_metadata","mp4_demuxer","mpeg_audio_decoder","ogg_demuxer","ogg_muxer","opus_decoder","opusfile_decoder","pcm_decoder","pcm_renderer_alsa","pcm_renderer_pa","spotify","vorbis_decoder","vp8_decoder","webm_demuxer","yuv_renderer"]' \
    "${_pkgname}" build
   samu -v -C build
   

2. See this build error:

   samu: job failed: sccache c++ -Iplayer/src/tizonia.p -Iplayer/src -I../tizonia/player/src -I../tizonia/player/src/services 
       -I../tizonia/player/src/services/googlemusic -I../tizonia/player/src/services/soundcloud -I../tizonia/player/src/services/youtube 
       -I../tizonia/player/src/services/plex -I../tizonia/player/src/services/tunein -I../tizonia/player/src/services/iheart -Iinclude/omxil-1.2 
       -I../tizonia/include/omxil-1.2 -I../tizonia/3rdparty/dbus-cplusplus/include -Ilibtizplatform/src -I../tizonia/libtizplatform/src 
       -Iplayer/dbus -I/usr/include/taglib -I/usr/include/ -I/usr/include/graphviz -I/usr/include -I/usr/include/python3.11 
       -I/var/tmp/tizonia-all-git/src/build -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -DHAVE_CONFIG_H 
       -include/var/tmp/tizonia-all-git/src/build/config.h -march=native -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat 
       -Werror=format-security -Wstrict-aliasing -Wno-deprecated -Wno-deprecated-declarations -fstack-clash-protection -fcf-protection 
       -fstack-protector-strong -Wp,-D_GLIBCXX_ASSERTIONS -Wno-unused-but-set-variable -flto=auto -Wno-error=address -Wno-address 
       -Wno-error=attribute-warning -Wno-attribute-warning -Wno-error=deprecated-declarations -Wno-deprecated-declarations 
       -Wno-error=format-security -Wno-format-security -Wno-error=strict-aliasing -Wno-strict-aliasing -Wno-error=unused-result -Wno-unused-result 
       -DBOOST_BIND_GLOBAL_PLACEHOLDERS=1 -pthread -DBOOST_CHRONO_DYN_LINK=1 -DBOOST_FILESYSTEM_DYN_LINK=1 -DBOOST_SYSTEM_DYN_LINK=1 
       -DBOOST_THREAD_BUILD_DLL=1 -DBOOST_THREAD_USE_DLL=1 -DBOOST_ALL_NO_LIB -DUNICODE -DSIZE_T_IS_LONG -DDBUS_API_SUBJECT_TO_CHANGE -MD -MQ 
       player/src/tizonia.p/services_iheart_tiziheartmgr.cpp.o -MF player/src/tizonia.p/services_iheart_tiziheartmgr.cpp.o.d -o 
       player/src/tizonia.p/services_iheart_tiziheartmgr.cpp.o -c ../tizonia/player/src/services/iheart/tiziheartmgr.cpp
   In file included from ../tizonia/player/src/tizgraphops.hpp:43,
                   from ../tizonia/player/src/services/iheart/tiziheartgraph.hpp:33,
                   from ../tizonia/player/src/services/iheart/tiziheartmgr.cpp:40:
   ../tizonia/player/src/tizprobe.hpp:122:9: error: ‘TagLib::uint’ has not been declared
     122 |         TagLib::uint (TagLib::Tag::*TagFunction)() const) const;
         |         ^~~~~~
   samu: subcommand failed
   

Expected behavior:

Succeeding compilation.

Actual behaviour:

Build error
tizprobe.hpp:122:9: error: ‘TagLib::uint’ has not been declared.

Reproduces how often:

At each bild with taglib 2.0.

Versions

Use the information obtained from tizonia --debug.

N/A since tizonia cannot be built.

Latest git checkout; latest commit: a1e8f8b from 2021-01-10.

Installation Method Used

Arch Linux AUR: Build from source.

---

Regards!

[PiyushPatle26]

Can I work on it ?

[dreirund]

Can I work on it ?

Of course. You can fix the issue and report here the patch, or fork the code into your own repository an work there.

This is not my project, I only reported the issue. The official project seems "dead' (not receiving updates anymore), so if you want to take over: Great!