Skip to content

Commit b254d39

Browse files
yngrdynmgadewoll
authored andcommitted
[dataset quality] Fix breakdown doc trend charts for wired streams (elastic#239147)
Closes elastic#239138. When we were sending the telemetry events we were relying on the dataset being in the shape of `${type}-${name}-${namespace}`, however this is not true anymore now that we support streams. Instead of saving a wrong value for `type`, we now send an empty value, we still can get the whole dataset name by looking into `index_name`. For the other values (`name`, `namespace`) we are also sending an empty value now. ### 🎥 Demo #### Before https://github.com/user-attachments/assets/e99adb3c-7e51-45fe-a9f3-1f88462ac573 #### After https://github.com/user-attachments/assets/ea1e0046-5b3f-4f86-83be-46e1b81f84c1
1 parent e4818ab commit b254d39

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

x-pack/platform/plugins/shared/dataset_quality/public/hooks/use_dataset_details_telemetry.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,9 @@ function getDatasetDetailsEbtProps({
170170
}): DatasetDetailsEbtProps {
171171
const indexName = datasetDetails.rawName;
172172
const dataStream = {
173-
dataset: datasetDetails.name,
174-
namespace: datasetDetails.namespace,
175-
type: datasetDetails.type,
173+
dataset: datasetDetails.name ?? '',
174+
namespace: datasetDetails.namespace ?? '',
175+
type: datasetDetails.name && datasetDetails.namespace ? datasetDetails.type : '',
176176
};
177177
const degradedDocs = dataStreamDetails?.degradedDocsCount ?? 0;
178178
const failedDocs = dataStreamDetails?.failedDocsCount ?? 0;

0 commit comments

Comments
 (0)